From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH v2] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Date: Thu, 20 Mar 2014 13:16:51 +0100 Message-ID: <532ADC33.5040607@redhat.com> References: <1395263249-16450-1-git-send-email-zoltan.kiss@citrix.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1395263249-16450-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Zoltan Kiss , Jesse Gross , pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org, dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Cc: netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Miklos Szeredi , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Michael S. Tsirkin" , Jason Wang , Eric Dumazet , Jan Beulich , Tom Herbert , Herbert Xu , Jozsef Kadlecsik , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, Pablo Neira Ayuso , Jiri Pirko , Paul Durrant , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Florian Westphal , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Borkmann , netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joe Perches , "David S. Miller" On 03/19/2014 10:07 PM, Zoltan Kiss wrote: > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well. > > Signed-off-by: Zoltan Kiss Acked-by: Thomas Graf > --- > + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) { > + skb_tx_error(to); > + return -ENOMEM; > + } Did you consider calling skb_tx_error() for Netlink message allocation failures for the upcall as well? That memory pressure is currently not reported back. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758529AbaCTNIX (ORCPT ); Thu, 20 Mar 2014 09:08:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54829 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbaCTNIV (ORCPT ); Thu, 20 Mar 2014 09:08:21 -0400 Message-ID: <532ADC33.5040607@redhat.com> Date: Thu, 20 Mar 2014 13:16:51 +0100 From: Thomas Graf Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Zoltan Kiss , Jesse Gross , pshelar@nicira.com, dev@openvswitch.org CC: "David S. Miller" , Pablo Neira Ayuso , Jozsef Kadlecsik , Eric Dumazet , Daniel Borkmann , Tom Herbert , Jason Wang , Florian Westphal , Joe Perches , Simon Horman , Jiri Pirko , "Michael S. Tsirkin" , Paul Durrant , Jan Beulich , Herbert Xu , Miklos Szeredi , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors References: <1395263249-16450-1-git-send-email-zoltan.kiss@citrix.com> In-Reply-To: <1395263249-16450-1-git-send-email-zoltan.kiss@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/19/2014 10:07 PM, Zoltan Kiss wrote: > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well. > > Signed-off-by: Zoltan Kiss Acked-by: Thomas Graf > --- > + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) { > + skb_tx_error(to); > + return -ENOMEM; > + } Did you consider calling skb_tx_error() for Netlink message allocation failures for the upcall as well? That memory pressure is currently not reported back.