From: Eli Billauer <eli.billauer@gmail.com>
To: monstr@monstr.eu
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
chris@printf.net, michal.simek@xilinx.com,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection
Date: Thu, 20 Mar 2014 14:39:27 +0200 [thread overview]
Message-ID: <532AE17F.9020509@gmail.com> (raw)
In-Reply-To: <532ADE8D.7040900@monstr.eu>
Hello Michal.
The Zybo board doesn't have any WP pin connected to the MicroSD card.
There is no physical possibility for the processor to know whether the
card is write-protected or not.
As I mentioned earlier, the practical problem can be worked around by
inverting the polarity of the WP bit, using wp-inverted. Practically
speaking, there's no need for this patch.
I insisted on this patch, because I think that the device tree should
reflect the hardware as it is, and not contain tricks for fooling the
driver into doing what we want. But I guess this wasn't a reason good
enough for adding yet another quirk (to the existing 38 or so).
Regards,
Eli
On 20/03/14 14:26, Michal Simek wrote:
> we have got this from Mike (we couldn't reply because he has lost this email
> thread.
>
> Mike:
> "I think I found the issue. In ps7_init.c as generated by the tools, it sets the "WP" pin not to EMIO, but to MIO 0. We use pin 0 for a status LED.
>
> # devmem 0XF8000830
> 0x002E0000
>
> Register 0XF8000830 is SD0_WP_CD_SEL, and 0x002E0000 sets CD to pin 46 and WP to pin "0", not to EMIO as I specified in the design.
> "
>
> Eli: Maybe you have the same issue as Mike. Can you please check it?
>
next prev parent reply other threads:[~2014-03-20 12:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 11:20 [PATCH v2] mmc: sdhci: add quirk for broken write protect detection Eli Billauer
2014-03-04 19:26 ` Sören Brinkmann
2014-03-04 19:26 ` Sören Brinkmann
2014-03-04 20:06 ` Eli Billauer
2014-03-04 21:00 ` Sören Brinkmann
2014-03-04 21:00 ` Sören Brinkmann
2014-03-06 13:31 ` Mike Looijmans
2014-03-06 13:31 ` Mike Looijmans
2014-03-06 16:42 ` Sören Brinkmann
2014-03-06 16:42 ` Sören Brinkmann
[not found] ` <ad0a3559-a687-4f51-b284-f515372cfad2-+Ck8Kgl/v09ZbvUCbuG1mrjjLBE8jN/0@public.gmane.org>
2014-03-20 12:26 ` Michal Simek
2014-03-20 12:26 ` Michal Simek
2014-03-20 12:39 ` Eli Billauer [this message]
2014-03-20 13:04 ` Mike Looijmans
2014-03-20 13:04 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AE17F.9020509@gmail.com \
--to=eli.billauer@gmail.com \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mike.looijmans@topic.nl \
--cc=monstr@monstr.eu \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.