From: Anna Schumaker <schumaker.anna@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] nfs: remove ->write_pageio_init from rpc ops
Date: Thu, 20 Mar 2014 08:50:19 -0400 [thread overview]
Message-ID: <532AE40B.4000807@gmail.com> (raw)
In-Reply-To: <20140320100414.GA28919@infradead.org>
On 03/20/2014 06:04 AM, Christoph Hellwig wrote:
> On Wed, Mar 19, 2014 at 01:47:22PM -0400, Anna Schumaker wrote:
>>> }
>>> -EXPORT_SYMBOL_GPL(nfs_pageio_init_write);
>> I think we still need the EXPORT_SYMBOL_GPL() here. Compiling gives me:
>>
>> ERROR: "nfs_pageio_init_read" [fs/nfs/nfsv4.ko] undefined!
>> ERROR: "nfs_pageio_init_write" [fs/nfs/nfsv4.ko] undefined!
> Oh right - I only tested built-in nfs. I have to say the amount of
> fairly low-level interfaces exported from the various nfs modules make a
> bit of a mess..
>
I'm open to suggestions about how to clean it all up! Fewer EXPORT_SYMBOLS wouldn't be a bad thing (along with fewer ifdefs and fewer rpc ops ...)
prev parent reply other threads:[~2014-03-20 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 16:40 [PATCH 1/2 v2] nfs: remove ->write_pageio_init from rpc ops Christoph Hellwig
2014-03-19 16:40 ` [PATCH 2/2 v2] nfs: remove ->read_pageio_init " Christoph Hellwig
2014-03-19 17:47 ` [PATCH 1/2 v2] nfs: remove ->write_pageio_init " Anna Schumaker
2014-03-20 10:04 ` Christoph Hellwig
2014-03-20 12:50 ` Anna Schumaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AE40B.4000807@gmail.com \
--to=schumaker.anna@gmail.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.