Re: [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data types in common header files

["Andreas Färber" <afaerber@suse.de>]

Am 20.03.2014 07:25, schrieb Stefan Weil:
> These header files are used by most QEMU source files. If they
> depend on windows.h, all those source files do so, too.
> 
> All Windows specific data types which are replaced use identical
> definitions for the 32 and 64 bit Windows APIs. HANDLE, LONG
> and CRITICAL_SECTION are replaced by the compatible types
> WinHandle, WinLong and WinCriticalSection.
> 
> Add an explicit dependency on qemu/winapi.h for some files which need it.
> These sources use the Windows API (see comment after include statement)
> and no longer get windows.h indirectly from other header files.
> 
> A workaround which was added in the previous patch is no longer needed.
> 
> Now 175 *.o files remain which still depend on windows.h.
> 
> Cc: Anthony Liguori <aliguori@amazon.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

For the record, I'm okay with WinHandle. I thought someone had
objections against some struct, but seems I missed either a discussion
or a respin.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg