From: Jens Axboe <axboe@fb.com>
To: Mike Snitzer <snitzer@redhat.com>, Dave Jones <davej@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: block: free q->flush_rq in blk_init_allocated_queue error paths.
Date: Thu, 20 Mar 2014 08:34:06 -0600 [thread overview]
Message-ID: <532AFC5E.8030401@fb.com> (raw)
In-Reply-To: <20140319192244.GA17654@redhat.com>
On 03/19/2014 01:22 PM, Mike Snitzer wrote:
> On Wed, Mar 19 2014 at 3:12pm -0400,
> Dave Jones <davej@redhat.com> wrote:
>
>> Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath flush")
>> moved an allocation to blk_init_allocated_queue(), but neglected to free
>> that allocation on the error paths that follow.
>>
>> Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> Ngh.. thanks Dave!
>
> /me hangs his head in shame...
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
>
> Jens, really sorry about this oversight. I can take it on the chin and
> pick this up for Linus to take this week from linux-dm.git. Your call.
No worries, I'll shove it off to Linus today. Then I can punch you on
the chin next week.
--
Jens Axboe
prev parent reply other threads:[~2014-03-20 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140318010053.D08A2660CC5@gitolite.kernel.org>
2014-03-19 19:12 ` block: free q->flush_rq in blk_init_allocated_queue error paths Dave Jones
2014-03-19 19:22 ` Mike Snitzer
2014-03-20 14:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AFC5E.8030401@fb.com \
--to=axboe@fb.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.