From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] SUNRPC: Ensure that call_connect times out correctly
Date: Thu, 20 Mar 2014 11:19:56 -0400 [thread overview]
Message-ID: <532B071C.3010208@RedHat.com> (raw)
In-Reply-To: <532AF753.8060607@RedHat.com>
On 03/20/2014 10:12 AM, Steve Dickson wrote:
>
>
> On 03/19/2014 03:41 PM, Trond Myklebust wrote:
>>
>> On Mar 19, 2014, at 14:22, Steve Dickson <SteveD@redhat.com> wrote:
>>>
>>> What's going on is-ECONNREFUSED is being seen in call_connect_status()
>>> and the task is not a soft connection. So call_timeout() is call which
>>> eventual times out the mount…
>>
>> This is what is confusing me. I’d expect that the rpc_ping() would be the
>> first thing to be sent on the wire by rpc_create(), and that ping
>> should normally have the RPC_SOFTCONN flag set.
>>
>>> So just for fun I make the SETCLIENTID rpc soft, but for some
>>> reason that didn't work either... I thought for sure it would...
> I see you point... Using quick systemtap scripts it turns out
> rpc_ping is not failing (returns 0x0) and it should because
> the server is definitely down!
Found it... The rpc_delay call in call_connect_status()
is causing a callback to be scheduled and run before
rpc_exit_task. Unfortunately that call back (__rpc_atrun)
clears the status...
I'll posting my version of the fix shortly..
steved.
next prev parent reply other threads:[~2014-03-20 15:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 18:40 [PATCH 1/2] SUNRPC: Ensure that call_connect times out correctly Trond Myklebust
2014-03-17 18:40 ` [PATCH 2/2] SUNRPC: Ensure that call_bind " Trond Myklebust
2014-03-18 19:02 ` Steve Dickson
2014-03-18 15:47 ` [PATCH 1/2] SUNRPC: Ensure that call_connect " Steve Dickson
2014-03-18 15:58 ` Trond Myklebust
2014-03-18 17:24 ` Steve Dickson
2014-03-18 18:45 ` Trond Myklebust
2014-03-18 19:00 ` Steve Dickson
2014-03-18 19:50 ` Trond Myklebust
2014-03-19 12:39 ` Steve Dickson
2014-03-19 12:52 ` Trond Myklebust
2014-03-19 14:07 ` Steve Dickson
2014-03-19 15:04 ` Trond Myklebust
2014-03-19 17:10 ` Steve Dickson
2014-03-19 17:29 ` Trond Myklebust
2014-03-19 18:22 ` Steve Dickson
2014-03-19 19:41 ` Trond Myklebust
2014-03-20 14:12 ` Steve Dickson
2014-03-20 15:19 ` Steve Dickson [this message]
2014-03-18 18:47 ` Steve Dickson
2014-03-18 18:48 ` Steve Dickson
2014-04-14 16:25 ` Jeff Layton
2014-04-14 16:57 ` Trond Myklebust
2014-04-14 17:32 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B071C.3010208@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.