From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WQfIy-0003rb-1h
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 11:54:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WQfIt-0003CN-BQ
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 11:54:51 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:57477)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WQfIt-0003CG-6H
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 11:54:47 -0400
Received: by mail-qc0-f178.google.com with SMTP id i8so1204972qcq.37
	for <qemu-devel@nongnu.org>; Thu, 20 Mar 2014 08:54:46 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <532B0F41.3040801@twiddle.net>
Date: Thu, 20 Mar 2014 08:54:41 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <532A1A30.3040306@caramail.com>
In-Reply-To: <532A1A30.3040306@caramail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] sparc32 : Signed integer division
	overflow
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olivier Danet <odanet@caramail.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

On 03/19/2014 03:29 PM, Olivier Danet wrote:
> The signed integer division -0x8000_0000_0000_0000 / -1 must be handled
> separately to avoid an overflow on the QEMU host.
> 
> Signed-off-by: Olivier Danet <odanet@caramail.com>
> ---
>  target-sparc/helper.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~