From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 10/17] xen: arm64: disable alignment traps Date: Thu, 20 Mar 2014 15:57:14 +0000 Message-ID: <532B0FDA.7070707@citrix.com> References: <1395330336.3104.12.camel@kazak.uk.xensource.com> <1395330365-9901-10-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1395330365-9901-10-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 20/03/14 15:45, Ian Campbell wrote: > The mem* primitives which I am about to import from Linux in a subsequent > patch rely on the hardware handling misalignment. > > The benefits of an optimised memcpy etc oughtweigh the downsides. > > Signed-off-by: Ian Campbell > --- > xen/arch/arm/arm64/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 9547ef5..22d0030 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -241,7 +241,7 @@ skip_bss: > * I-cache enabled, > * Alignment checking enabled, Is this comment still true? ~Andrew > * MMU translation disabled (for now). */ > - ldr x0, =(HSCTLR_BASE|SCTLR_A) > + ldr x0, =(HSCTLR_BASE) > msr SCTLR_EL2, x0 > > /* Rebuild the boot pagetable's first-level entries. The structure