From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WQgt7-0006O7-2S for mharc-qemu-trivial@gnu.org; Thu, 20 Mar 2014 13:36:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQgt0-0006DH-8L for qemu-trivial@nongnu.org; Thu, 20 Mar 2014 13:36:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQgst-0000Ua-E0 for qemu-trivial@nongnu.org; Thu, 20 Mar 2014 13:36:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQgst-0000UT-60; Thu, 20 Mar 2014 13:36:03 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2KHZwAN021432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Mar 2014 13:35:59 -0400 Received: from yakj.usersys.redhat.com (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2KHZtbh013646; Thu, 20 Mar 2014 13:35:56 -0400 Message-ID: <532B26FA.80900@redhat.com> Date: Thu, 20 Mar 2014 18:35:54 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: BALATON Zoltan References: <20140227011300.8CD451983B@mono.eik.bme.hu> <532B0C5D.5060905@msgid.tls.msk.ru> <532B0E71.1000009@redhat.com> <532B180F.5080301@redhat.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Mar 2014 17:36:16 -0000 Il 20/03/2014 17:58, BALATON Zoltan ha scritto: >> >> Classes (or anything guest-visible in fact) must never ever be changed >> for the same machine type. It's a rule. > > The class did not change only the prog interface field after it (which > is guest visible but I think most guests just ignore it). So then what's > the correct way to do it? Do I need to change the patch or can it be > merged as it is the next time a new machine type is added? You can wait for the 2.1 machine type to be added. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQgtC-0006YE-83 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 13:36:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQgt6-0000Wh-8Z for qemu-devel@nongnu.org; Thu, 20 Mar 2014 13:36:22 -0400 Message-ID: <532B26FA.80900@redhat.com> Date: Thu, 20 Mar 2014 18:35:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20140227011300.8CD451983B@mono.eik.bme.hu> <532B0C5D.5060905@msgid.tls.msk.ru> <532B0E71.1000009@redhat.com> <532B180F.5080301@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org Il 20/03/2014 17:58, BALATON Zoltan ha scritto: >> >> Classes (or anything guest-visible in fact) must never ever be changed >> for the same machine type. It's a rule. > > The class did not change only the prog interface field after it (which > is guest visible but I think most guests just ignore it). So then what's > the correct way to do it? Do I need to change the patch or can it be > merged as it is the next time a new machine type is added? You can wait for the 2.1 machine type to be added. Paolo