All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qiaonuohan <qiaonuohan@cn.fujitsu.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] hmp interface for kdump compressed format
Date: Thu, 20 Mar 2014 22:51:59 +0100	[thread overview]
Message-ID: <532B62FF.9030804@redhat.com> (raw)
In-Reply-To: <532B5D70.4030808@redhat.com>

Il 20/03/2014 22:28, Laszlo Ersek ha scritto:
> On 03/20/14 22:18, Christian Borntraeger wrote:
>> On 20/03/14 21:56, Laszlo Ersek wrote:
>>> On 03/20/14 21:38, Christian Borntraeger wrote:
>>>> Qiao Nuohan,
>>>>
>>>> is there a reason why you did not implemented the HMP part for that format
>>>> of kdump compressed format? After all this is a patch mostly for developers,
>>>> so a HMP interface might come handy. Do you already have some patch in
>>>> preparation or know somebody doing it?
>>>
>>> http://thread.gmane.org/gmane.comp.emulators.qemu/249283/focus=250059
>>>
>>> Laszlo
>>>
>> So in essence: Due to the limitations of the command line parser we cannot
>> add the format to the hmp command line.
>> So something like adding
>>
>> dump_guest_memory_set_format <format>
>>
>> would be the only possible solution with the hmp code as is. Correct?
>
> Yes, one possibility would be to make the dump command stateful (=
> compression format), and to add a new command setting/getting that state.
>
> Another option would be to leave the current command intact, and add an
> independent command that wouldn't take "begin", "end", nor "paging", but
> would take compression format.

Another possibility is to kill begin/length from the dump-guest-memory 
command.  HMP is not stable, so if that's useful we can do it.

Paolo

  reply	other threads:[~2014-03-20 21:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 20:38 [Qemu-devel] hmp interface for kdump compressed format Christian Borntraeger
2014-03-20 20:56 ` Laszlo Ersek
2014-03-20 21:12   ` Laszlo Ersek
2014-03-20 21:18   ` Christian Borntraeger
2014-03-20 21:28     ` Laszlo Ersek
2014-03-20 21:51       ` Paolo Bonzini [this message]
2014-03-21  9:31         ` qiaonuohan
2014-03-21  9:38           ` Christian Borntraeger
2014-03-26 17:04           ` Markus Armbruster
2014-03-27  1:22             ` qiaonuohan
2014-03-27  8:38               ` Markus Armbruster
2014-04-02  1:54                 ` qiaonuohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532B62FF.9030804@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qiaonuohan@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.