From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP
Date: Thu, 20 Mar 2014 23:08:02 +0100
Message-ID: <532B66C2.9020605@redhat.com>
References: <1395154495-22807-1-git-send-email-pbonzini@redhat.com>	 <1395154495-22807-5-git-send-email-pbonzini@redhat.com> <1395347087.632.38.camel@ul30vt.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com,
	kvm@vger.kernel.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1395347087.632.38.camel@ul30vt.home>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Il 20/03/2014 21:24, Alex Williamson ha scritto:
>> >
>> > +void kvm_ioapic_inject_all(struct kvm_ioapic *ioapic, unsigned long irr)
>> > +{
> nit, kvm_ioapic_state.irr is a u32

Yes, but for_each_set_bit requires unsigned long.

>> > +	u32 idx;
>> > +
>> > +	rtc_irq_eoi_tracking_reset(ioapic);
>> > +	for_each_set_bit(idx, &irr, 32) {
>
> Can we use IOAPIC_NUM_PINS in place of 32?

Yes, indeeed.

> > +		printk("ioapic_service for GSI %d\n", idx);
>
> Is this leftover debugging?  Maybe give it a loglevel if it's
> intentional.  Looks reasonable otherwise.  Thanks,

I'll remove it.  Thanks for the review!

Paolo