From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <532BCFCC.4080205@freescale.com> Date: Fri, 21 Mar 2014 13:36:12 +0800 From: Huang Shijie MIME-Version: 1.0 To: Subject: Re: [PATCH] mtd: gpmi: make blockmark swapping optional References: <1395235406-13449-1-git-send-email-y> In-Reply-To: <1395235406-13449-1-git-send-email-y> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Cc: Fabio Estevam , Mark Rutland , Russell King , Pawel Moll , Arnd Bergmann , Ian Campbell , Artem Bityutskiy , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rob Landley , Kumar Gala , Brian Norris , David Woodhouse , Sascha Hauer , Shawn Guo , =?UTF-8?B?TG90aGFyIFdhw59tYW5u?= List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , =E4=BA=8E 2014=E5=B9=B403=E6=9C=8819=E6=97=A5 21:23, y@karo-electronics.d= e =E5=86=99=E9=81=93: > + /* Set up swap_block_mark, must be set before the gpmi_set_geometry()= */ > + if (!of_property_read_bool(this->dev->of_node, "fsl,no-blockmark-swap= ")) > + this->swap_block_mark =3D !GPMI_IS_MX23(this); Our ROM guy had confirmed that the Rom will disable the swapping if we=20 set the DISBBM bit. But please do not change any logic for imx23/imx28. I really do not know what's the benefit we can get from this patch. Please send the new version about this patch if you want this feature. thanks Huang Shijie From mboxrd@z Thu Jan 1 00:00:00 1970 From: b32955@freescale.com (Huang Shijie) Date: Fri, 21 Mar 2014 13:36:12 +0800 Subject: [PATCH] mtd: gpmi: make blockmark swapping optional In-Reply-To: <1395235406-13449-1-git-send-email-y> References: <1395235406-13449-1-git-send-email-y> Message-ID: <532BCFCC.4080205@freescale.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2014?03?19? 21:23, y at karo-electronics.de ??: > + /* Set up swap_block_mark, must be set before the gpmi_set_geometry() */ > + if (!of_property_read_bool(this->dev->of_node, "fsl,no-blockmark-swap")) > + this->swap_block_mark = !GPMI_IS_MX23(this); Our ROM guy had confirmed that the Rom will disable the swapping if we set the DISBBM bit. But please do not change any logic for imx23/imx28. I really do not know what's the benefit we can get from this patch. Please send the new version about this patch if you want this feature. thanks Huang Shijie From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Shijie Subject: Re: [PATCH] mtd: gpmi: make blockmark swapping optional Date: Fri, 21 Mar 2014 13:36:12 +0800 Message-ID: <532BCFCC.4080205@freescale.com> References: <1395235406-13449-1-git-send-email-y> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1395235406-13449-1-git-send-email-y> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: y@karo-electronics.de Cc: Fabio Estevam , Mark Rutland , Russell King , Pawel Moll , Arnd Bergmann , Ian Campbell , Artem Bityutskiy , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rob Landley , Kumar Gala , Brian Norris , David Woodhouse , Sascha Hauer , Shawn Guo , =?UTF-8?B?TG90aGFyIFdhw59tYW5u?= List-Id: devicetree@vger.kernel.org 5LqOIDIwMTTlubQwM+aciDE55pelIDIxOjIzLCB5QGthcm8tZWxlY3Ryb25pY3MuZGUg5YaZ6YGT Ogo+ICsJLyogU2V0IHVwIHN3YXBfYmxvY2tfbWFyaywgbXVzdCBiZSBzZXQgYmVmb3JlIHRoZSBn cG1pX3NldF9nZW9tZXRyeSgpICovCj4gKwlpZiAoIW9mX3Byb3BlcnR5X3JlYWRfYm9vbCh0aGlz LT5kZXYtPm9mX25vZGUsICJmc2wsbm8tYmxvY2ttYXJrLXN3YXAiKSkKPiArCQl0aGlzLT5zd2Fw X2Jsb2NrX21hcmsgPSAhR1BNSV9JU19NWDIzKHRoaXMpOwoKCk91ciBST00gZ3V5IGhhZCBjb25m aXJtZWQgdGhhdCB0aGUgUm9tIHdpbGwgZGlzYWJsZSB0aGUgc3dhcHBpbmcgaWYgd2UgCnNldCB0 aGUgRElTQkJNIGJpdC4KQnV0IHBsZWFzZSBkbyBub3QgY2hhbmdlIGFueSBsb2dpYyBmb3IgaW14 MjMvaW14MjguCgpJIHJlYWxseSBkbyBub3Qga25vdyB3aGF0J3MgdGhlIGJlbmVmaXQgd2UgY2Fu IGdldCBmcm9tIHRoaXMgcGF0Y2guClBsZWFzZSBzZW5kIHRoZSBuZXcgdmVyc2lvbiBhYm91dCB0 aGlzIHBhdGNoIGlmIHlvdSB3YW50IHRoaXMgZmVhdHVyZS4KCgp0aGFua3MKSHVhbmcgU2hpamll CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755254AbaCUFhO (ORCPT ); Fri, 21 Mar 2014 01:37:14 -0400 Received: from [216.32.180.11] ([216.32.180.11]:43627 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752119AbaCUFhL convert rfc822-to-8bit (ORCPT ); Fri, 21 Mar 2014 01:37:11 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: 5 X-BigFish: VS5(zzc89bhzz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6h1082kz4ejz1de098h1de097hz2dh2a8h4a8h839h93fhd25he5bhf0ah1288h12a5h12a9h12bdh1354h137ah13b6h1441h1504h1537h153bh162dh1631h1758h1765h18e1h190ch1946h19c3h1ad9h1b0ah1b2fh2222h224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1f5fh1fe8h1ff5h209eh22d0h2336h2438h2461h2487h24d7h2516h2545h255eh25cch25f6h2605h1155h) Message-ID: <532BCFCC.4080205@freescale.com> Date: Fri, 21 Mar 2014 13:36:12 +0800 From: Huang Shijie User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Thunderbird/3.1.16 MIME-Version: 1.0 To: CC: Arnd Bergmann , Artem Bityutskiy , Brian Norris , David Woodhouse , Fabio Estevam , Ian Campbell , Kumar Gala , =?UTF-8?B?TG90aGFyIFdhw59tYW5u?= , Mark Rutland , Pawel Moll , Rob Herring , Rob Landley , Russell King , Sascha Hauer , Shawn Guo , , , , , Subject: Re: [PATCH] mtd: gpmi: make blockmark swapping optional References: <1395235406-13449-1-git-send-email-y> In-Reply-To: <1395235406-13449-1-git-send-email-y> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-FOPE-CONNECTOR: Id%0$Dn%FREESCALE.MAIL.ONMICROSOFT.COM$RO%1$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2014年03月19日 21:23, y@karo-electronics.de 写道: > + /* Set up swap_block_mark, must be set before the gpmi_set_geometry() */ > + if (!of_property_read_bool(this->dev->of_node, "fsl,no-blockmark-swap")) > + this->swap_block_mark = !GPMI_IS_MX23(this); Our ROM guy had confirmed that the Rom will disable the swapping if we set the DISBBM bit. But please do not change any logic for imx23/imx28. I really do not know what's the benefit we can get from this patch. Please send the new version about this patch if you want this feature. thanks Huang Shijie