From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH] drm/exynos: remove DRIVER_HAVE_IRQ feature Date: Fri, 21 Mar 2014 16:26:20 +0900 Message-ID: <532BE99C.4090203@samsung.com> References: <1395383951-5293-1-git-send-email-jy0922.shim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 044E36E133 for ; Fri, 21 Mar 2014 00:26:12 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2R00CS9ZBNSPD0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 21 Mar 2014 16:26:11 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Kurtz Cc: Kyungmin Park , Seung-Woo Kim , dri-devel List-Id: dri-devel@lists.freedesktop.org On 03/21/2014 03:53 PM, Daniel Kurtz wrote: > On Fri, Mar 21, 2014 at 2:39 PM, Joonyoung Shim wrote: >> Exynos drm driver cannot support DRIVER_HAVE_IRQ feature because it uses >> driver specific one instead of routine of drm framework to >> install/uninstall irq handler. > Wouldn't that break synchronous drm_wait_vblank()? > (drm_wait_vblank where _DRM_VBLANK_EVENT is not set in request.type) Actually, i didn't consider above case. Then it seems to need code to set dev->irq_enabled in exynos driver. Thanks. > -Dan > >> Signed-off-by: Joonyoung Shim >> --- >> drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +-- >> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10 ---------- >> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 10 ---------- >> 3 files changed, 1 insertion(+), 22 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> index c204b4e..dd7d18f 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> @@ -291,8 +291,7 @@ static const struct file_operations exynos_drm_driver_fops = { >> }; >> >> static struct drm_driver exynos_drm_driver = { >> - .driver_features = DRIVER_HAVE_IRQ | DRIVER_MODESET | >> - DRIVER_GEM | DRIVER_PRIME, >> + .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME, >> .load = exynos_drm_load, >> .unload = exynos_drm_unload, >> .open = exynos_drm_open, >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c >> index a20440c..37455f3 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c >> @@ -715,16 +715,6 @@ out: >> static int fimd_subdrv_probe(struct drm_device *drm_dev, struct device *dev) >> { >> /* >> - * enable drm irq mode. >> - * - with irq_enabled = true, we can use the vblank feature. >> - * >> - * P.S. note that we wouldn't use drm irq handler but >> - * just specific driver own one instead because >> - * drm framework supports only one irq handler. >> - */ >> - drm_dev->irq_enabled = true; >> - >> - /* >> * with vblank_disable_allowed = true, vblank interrupt will be disabled >> * by drm timer once a current process gives up ownership of >> * vblank event.(after drm_vblank_put function is called) >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c >> index ddaaedd..b4c5f95 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c >> @@ -382,16 +382,6 @@ static void vidi_fake_vblank_handler(struct work_struct *work) >> static int vidi_subdrv_probe(struct drm_device *drm_dev, struct device *dev) >> { >> /* >> - * enable drm irq mode. >> - * - with irq_enabled = true, we can use the vblank feature. >> - * >> - * P.S. note that we wouldn't use drm irq handler but >> - * just specific driver own one instead because >> - * drm framework supports only one irq handler. >> - */ >> - drm_dev->irq_enabled = true; >> - >> - /* >> * with vblank_disable_allowed = true, vblank interrupt will be disabled >> * by drm timer once a current process gives up ownership of >> * vblank event.(after drm_vblank_put function is called) >> -- >> 1.8.1.2 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel