From: Lars-Peter Clausen <lars@metafoo.de>
To: Jimmy Li <coder.liss@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix some coding style in drivers/staging/iio
Date: Fri, 21 Mar 2014 08:35:41 +0100 [thread overview]
Message-ID: <532BEBCD.3020002@metafoo.de> (raw)
In-Reply-To: <20140321044546.GA12515@gmail.com>
[...]
> diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
> index 6f38ca9..31c7a9d 100644
> --- a/drivers/staging/iio/accel/adis16220_core.c
> +++ b/drivers/staging/iio/accel/adis16220_core.c
> @@ -392,7 +392,8 @@ static const struct iio_info adis16220_info = {
> };
>
> static const char * const adis16220_status_error_msgs[] = {
> - [ADIS16220_DIAG_STAT_VIOLATION_BIT] = "Capture period violation/interruption",
> + [ADIS16220_DIAG_STAT_VIOLATION_BIT] =
> + "Capture period violation/interruption",
This does not improve legibility. The 80 chars per line rule is to improve
legibility, if it doesn't it's better to ignore it.
> [ADIS16220_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
> [ADIS16220_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed",
> [ADIS16220_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
[...]
> diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
> index 36eedd8..d38df2e 100644
> --- a/drivers/staging/iio/resolver/ad2s1200.c
> +++ b/drivers/staging/iio/resolver/ad2s1200.c
> @@ -70,6 +70,7 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev,
> vel = (((s16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4);
> vel = (vel << 4) >> 4;
> *val = vel;
> + /* fall through */
This not a coding style issue, here is actually a break missing.
> default:
> mutex_unlock(&st->lock);
> return -EINVAL;
>
prev parent reply other threads:[~2014-03-21 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 4:45 [PATCH] fix some coding style in drivers/staging/iio Jimmy Li
2014-03-21 7:35 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532BEBCD.3020002@metafoo.de \
--to=lars@metafoo.de \
--cc=coder.liss@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.