All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, shadowsor@gmail.com, famz@redhat.com,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCHv2] block: introduce BDRV_O_SEQUENTIAL
Date: Fri, 21 Mar 2014 13:42:29 +0100	[thread overview]
Message-ID: <532C33B5.9030305@kamp.de> (raw)
In-Reply-To: <532C2B38.7050708@redhat.com>

On 21.03.2014 13:06, Paolo Bonzini wrote:
> Il 21/03/2014 12:49, Peter Lieven ha scritto:
>> A 10G logical volume was created and filled with random data.
>> Then the logical volume was exported via qemu-img convert to an iscsi target.
>> Before the export was started all caches of the linux kernel where dropped.
>>
>> Old behavior:
>>  - The convert process took 3m45s and the buffer cache grew up to 9.67 GB close
>>    to the end of the conversion. After qemu-img terminated all the buffers were
>>    freed by the kernel.
>>
>> New behavior with the -N switch:
>>  - The convert process took 3m43s and the buffer cache grew up to 15.48 MB close
>>    to the end with some small peaks up to 30 MB durine the conversion.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>> v1->v2: - added test example to commit msg
>>         - added -N knob to qemu-img
>
> I'm sorry, I cannot find the original discussion.  Why is the new knob needed?

The thread was named "qemu-img convert cache mode for source".

I think the 2 points (mainly by Marcus) were that you would not expect qemu-img
to mangle with the page cache by default as you would not expect it from cp or dd.
And secondly, if a running vServer and the image that is converted share pages it
can ruin the vServers cache.

Peter

  reply	other threads:[~2014-03-21 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 11:49 [Qemu-devel] [PATCHv2] block: introduce BDRV_O_SEQUENTIAL Peter Lieven
2014-03-21 12:06 ` Paolo Bonzini
2014-03-21 12:42   ` Peter Lieven [this message]
2014-03-28 10:02   ` Peter Lieven
2014-03-24  9:18 ` Fam Zheng
2014-03-24 14:02   ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532C33B5.9030305@kamp.de \
    --to=pl@kamp.de \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shadowsor@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.