From: Christopher Covington <cov@codeaurora.org>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@parallels.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, James Morris <jmorris@namei.org>,
Patrick McHardy <kaber@trash.net>,
criu@openvz.org, Eric Dumazet <edumazet@google.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [CRIU] [PATCH 3/3] tcp: add ability to restore a fin packet
Date: Fri, 21 Mar 2014 10:04:07 -0400 [thread overview]
Message-ID: <532C46D7.9050403@codeaurora.org> (raw)
In-Reply-To: <1395408781-8145-4-git-send-email-avagin@openvz.org>
On 03/21/2014 09:33 AM, Andrey Vagin wrote:
> It's required for restoring sockets in closing states:
> TCP_FIN_WAIT{1,2}, TCP_WAIT_STOP, TCP_CLOSING, TCP_LAST_ACK.
>
> A fin packet is restored by sending a control message (ancillary data).
> In which queue a packet is restored depends on a value of
> tp->repair_queue.
>
> This interface is choosen, because we are goint to use sendmsg for
Nit: chosen, going
> --- a/include/uapi/linux/tcp.h
> +++ b/include/uapi/linux/tcp.h
> @@ -199,4 +199,7 @@ struct tcp_md5sig {
> __u8 tcpm_key[TCP_MD5SIG_MAXKEYLEN]; /* key (binary) */
> };
>
> +/* Conntroll message types to repair tcp connections */
Nit: Control
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-03-21 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 13:32 [PATCH RFC 0/3] tcp: allow to repair a tcp connections in closing states Andrey Vagin
2014-03-21 13:32 ` [PATCH 1/3] tcp: allow to enable repair mode for sockets in any state Andrey Vagin
2014-03-24 22:47 ` Pavel Emelyanov
2014-03-21 13:33 ` [PATCH 2/3] tcp: check repair before fastopen in tcp_sendmsg Andrey Vagin
2014-03-21 13:33 ` [PATCH 3/3] tcp: add ability to restore a fin packet Andrey Vagin
2014-03-21 14:04 ` Christopher Covington [this message]
2014-03-24 23:29 ` [PATCH RFC 0/3] tcp: allow to repair a tcp connections in closing states David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C46D7.9050403@codeaurora.org \
--to=cov@codeaurora.org \
--cc=avagin@openvz.org \
--cc=criu@openvz.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gorcunov@openvz.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.