From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] tools/libxl: libxl_get_scheduler should return an int Date: Fri, 21 Mar 2014 15:14:33 +0000 Message-ID: <532C5759.5010807@linaro.org> References: <1395404743-13833-1-git-send-email-julien.grall@linaro.org> <21292.19607.305924.483523@mariner.uk.xensource.com> <532C4F45.6020101@linaro.org> <21292.21622.375572.803747@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WR19Z-0005ms-LV for xen-devel@lists.xenproject.org; Fri, 21 Mar 2014 15:14:37 +0000 Received: by mail-wi0-f179.google.com with SMTP id f8so609935wiw.12 for ; Fri, 21 Mar 2014 08:14:36 -0700 (PDT) In-Reply-To: <21292.21622.375572.803747@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 03/21/2014 03:02 PM, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH v2] tools/libxl: libxl_get_scheduler should return an int"): >> On 03/21/2014 02:28 PM, Ian Jackson wrote: >>> But then I don't understand why you changed this too. Either of these >>> changes would suffice by itself, and the former is marginally less >>> fiddly. >> >> The variable sched is a libxl_scheduler in this function. I can't modify >> the type because it's used with lixbl_scheduler_from_string (see >> xl_cmdimpl.c:6703). > > Ah. I think libxl_scheduler_from_string should be changed too. libxl_scheduler_from_string is similar to all libxl*_from_string enum function. If we change this function we should also modify libxl_bios_type_from_string, libxl_timer_mode_from_string... Regards, -- Julien Grall