From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WR1Hy-0008JF-L7
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:23:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WR1Ht-0004Io-Ul
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:23:18 -0400
Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:46808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WR1Ht-0004Ic-PI
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:23:13 -0400
Received: by mail-qg0-f49.google.com with SMTP id z60so7434951qgd.8
	for <qemu-devel@nongnu.org>; Fri, 21 Mar 2014 08:23:12 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <532C595C.4070605@twiddle.net>
Date: Fri, 21 Mar 2014 08:23:08 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <532B94FF.4090809@caramail.com>
In-Reply-To: <532B94FF.4090809@caramail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olivier Danet <odanet@caramail.com>, qemu-devel <qemu-devel@nongnu.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Blue Swirl <blauwirbel@gmail.com>

On 03/20/2014 06:25 PM, Olivier Danet wrote:
> The signed integer division -0x8000_0000_0000_0000 / -1 must be handled
> separately to avoid an overflow on the QEMU host.
> 
> Negative overflow must be a negative number for correct sign
> extension in Sparc64 mode. Use <stdint.h> constants.
> 
> Signed-off-by: Olivier Danet <odanet@caramail.com>
> ---
>  target-sparc/helper.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~