From: Richard Henderson <rth@twiddle.net>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Olivier Danet <odanet@caramail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow
Date: Fri, 21 Mar 2014 08:23:45 -0700 [thread overview]
Message-ID: <532C5981.4040406@twiddle.net> (raw)
In-Reply-To: <532BE51E.7060208@ilande.co.uk>
On 03/21/2014 12:07 AM, Mark Cave-Ayland wrote:
>
> This basic patch looks good to me. My only comment is that I suspect for
> bisection purposes it may be better to split this into 2 patches - one to
> perform the conversion of all existing constants to INT*_MAX and INT*_MIN, and
> then a second to add your change to prevent the crash. I'll let Richard have
> the final say though.
I think one patch is fine.
r~
next prev parent reply other threads:[~2014-03-21 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 1:25 [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow Olivier Danet
2014-03-21 7:07 ` Mark Cave-Ayland
2014-03-21 15:23 ` Richard Henderson [this message]
2014-03-21 15:23 ` Richard Henderson
2014-03-24 21:07 ` Mark Cave-Ayland
2014-03-24 21:36 ` Peter Maydell
2014-03-24 22:43 ` Andreas Färber
2014-03-26 15:03 ` Mark Cave-Ayland
2014-03-26 15:20 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C5981.4040406@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=odanet@caramail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.