From: Julien Grall <julien.grall@linaro.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
ian.campbell@citrix.com
Subject: Re: [PATCH v2] tools/libxl: libxl_get_scheduler should return an int
Date: Fri, 21 Mar 2014 15:25:12 +0000 [thread overview]
Message-ID: <532C59D8.6060205@linaro.org> (raw)
In-Reply-To: <21292.22774.633646.324324@mariner.uk.xensource.com>
On 03/21/2014 03:21 PM, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH v2] tools/libxl: libxl_get_scheduler should return an int"):
>> On 03/21/2014 03:02 PM, Ian Jackson wrote:
>>> Ah. I think libxl_scheduler_from_string should be changed too.
>>
>> libxl_scheduler_from_string is similar to all libxl*_from_string enum
>> function. If we change this function we should also modify
>> libxl_bios_type_from_string, libxl_timer_mode_from_string...
>
> Yes...
I'm not sure to understand, do you I need to do a s/enum .../int/?
If so, there will be some issue on every caller to this function.
Because enum * is not compatible with int *.
--
Julien Grall
next prev parent reply other threads:[~2014-03-21 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 12:25 [PATCH v2] tools/libxl: libxl_get_scheduler should return an int Julien Grall
2014-03-21 12:43 ` Ian Campbell
2014-03-21 14:31 ` Ian Jackson
2014-03-21 14:50 ` Julien Grall
2014-03-21 15:06 ` Ian Jackson
2014-03-21 14:28 ` Ian Jackson
2014-03-21 14:40 ` Julien Grall
2014-03-21 15:02 ` Ian Jackson
2014-03-21 15:14 ` Julien Grall
2014-03-21 15:21 ` Ian Jackson
2014-03-21 15:25 ` Julien Grall [this message]
2014-03-21 16:11 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C59D8.6060205@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.