From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR1PR-0000aT-Fh for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WR1PM-00070T-JK for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:31:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR1PM-00070A-9c for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:30:56 -0400 Message-ID: <532C5B18.4080904@redhat.com> Date: Fri, 21 Mar 2014 16:30:32 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1395097833-3021-1-git-send-email-l@dorileo.org> <532C4EB4.6030506@redhat.com> <20140321145611.GD22259@dorilex> In-Reply-To: <20140321145611.GD22259@dorilex> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] QemuOpt: add unit tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Leandro Dorileo , Stefan Hajnoczi , qemu-devel@nongnu.org, Markus Armbruster , Anthony Liguori , Chunyan Liu , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Wenchao Xia On 03/21/14 15:56, Leandro Dorileo wrote: > Hi Eric, > > On Fri, Mar 21, 2014 at 08:37:40AM -0600, Eric Blake wrote: >> On 03/17/2014 05:10 PM, Leandro Dorileo wrote: >>> Cover basic aspects and API usage for QemuOpt. The current implementation >>> covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter >>> replacement/cleanup job. >>> >>> Other APIs should be covered in future improvements. >>> >>> Signed-off-by: Leandro Dorileo >> >> Right here is where you should stick a --- marker. >> >>> >>> Changes: >>> v2: >>> + fixed comments; >>> + make use of g_assert_cmpstr(); >>> + use error_abort instead of a local_err for qemu_opts_absorb_qdict(); >>> + asserts on QemuOptsList (empty and list name); >>> + added test_qemu_opt_unset(); >>> + asserts on qemu_opt_*_set() return; >>> + added test_qemu_opts_reset(); >>> + added test_qemu_opts_set(); >>> --- >> >> It's okay to have a duplicate one; but the main point is that the v2 >> changelog is useful to reviewers but not to the git log; and anything >> after the --- marker gets omitted by 'git am' when a maintainer accepts >> your patch into their pull request. > > I would say that I even know about the --- marker, but have misplaced it... :( Off-topic: I suggest to include a reference to git-notes(1) in our patch submission guidelines. - git-notes(1) lets you manage such v(n)->v(n+1) changelogs inside git, - the notes are pushable, - they are carried across rebases, - they are *not* part of the commit messages (consequently, they are not part of the commit hashes either), - they are (can be) correctly displayed by git-log, git-show, gitk, and git-format-patch (notably, in the last case, under the --- separator) When you start using git-notes, you don't understand how you could exist without it. Git-notes(1) takes some minimal configuration before use; the web offers easily searchable, good advice. Thanks, Laszlo