From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from b.ns.miles-group.at ([95.130.255.144] helo=radon.swed.at) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WR9Jn-0005QM-6k for linux-mtd@lists.infradead.org; Fri, 21 Mar 2014 23:57:44 +0000 Message-ID: <532CD1CB.4070707@nod.at> Date: Sat, 22 Mar 2014 00:56:59 +0100 From: Richard Weinberger MIME-Version: 1.0 To: Mike Snitzer Subject: Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map References: <20140321195403.GA32529@redhat.com> In-Reply-To: <20140321195403.GA32529@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Artem Bityutskiy List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 21.03.2014 20:54, schrieb Mike Snitzer: > The comparisons used in add_vol() shouldn't be identical. Pretty sure > the following is correct but it is completely untested. > > Signed-off-by: Mike Snitzer > --- > drivers/mtd/ubi/fastmap.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > NOTE: I stumbled upon this code while implementing some rb_tree code > (and looking for some existing rb_tree code as a reference). Thanks a lot for pointing this out! Acked-by: Richard Weinberger Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbaCUX5W (ORCPT ); Fri, 21 Mar 2014 19:57:22 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751002AbaCUX5V (ORCPT ); Fri, 21 Mar 2014 19:57:21 -0400 Message-ID: <532CD1CB.4070707@nod.at> Date: Sat, 22 Mar 2014 00:56:59 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Mike Snitzer CC: linux-kernel@vger.kernel.org, Artem Bityutskiy , linux-mtd@lists.infradead.org Subject: Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map References: <20140321195403.GA32529@redhat.com> In-Reply-To: <20140321195403.GA32529@redhat.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 21.03.2014 20:54, schrieb Mike Snitzer: > The comparisons used in add_vol() shouldn't be identical. Pretty sure > the following is correct but it is completely untested. > > Signed-off-by: Mike Snitzer > --- > drivers/mtd/ubi/fastmap.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > NOTE: I stumbled upon this code while implementing some rb_tree code > (and looking for some existing rb_tree code as a reference). Thanks a lot for pointing this out! Acked-by: Richard Weinberger Thanks, //richard