From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35467)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WRHmK-0003n0-3v
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 04:59:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WRHmE-0002LX-Ut
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 04:59:44 -0400
Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:60498)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WRHmE-0002LM-NY
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 04:59:38 -0400
Received: by mail-ee0-f51.google.com with SMTP id c13so2591599eek.10
	for <qemu-devel@nongnu.org>; Sat, 22 Mar 2014 01:59:37 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <532D50F6.4040407@redhat.com>
Date: Sat, 22 Mar 2014 09:59:34 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1395429454-24690-1-git-send-email-fred.konrad@greensocs.com>
	<1395429454-24690-5-git-send-email-fred.konrad@greensocs.com>
In-Reply-To: <1395429454-24690-5-git-send-email-fred.konrad@greensocs.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 04/12] icount: introduce icount timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com, qemu-devel@nongnu.org
Cc: mark.burton@greensocs.com

Il 21/03/2014 20:17, fred.konrad@greensocs.com ha scritto:
> @@ -154,7 +159,20 @@ int64_t cpu_get_icount(void)
>
>      do {
>          start = seqlock_read_begin(&timers_state.vm_clock_seqlock);
> -        icount = cpu_get_icount_locked();
> +        icount = cpu_get_icount_locked(true);
> +    } while (seqlock_read_retry(&timers_state.vm_clock_seqlock, start));
> +
> +    return icount;
> +}
> +
> +int64_t cpu_get_icount_wo_bias(void)
> +{
> +    int64_t icount;
> +    unsigned start;
> +
> +    do {
> +        start = seqlock_read_begin(&timers_state.vm_clock_seqlock);
> +        icount = cpu_get_icount_locked(false);
>      } while (seqlock_read_retry(&timers_state.vm_clock_seqlock, start));

Why not add an argument to cpu_get_icount() as well?

Paolo