Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements

[Paolo Bonzini <pbonzini@redhat.com>]

Il 22/03/2014 00:42, Cole Robinson ha scritto:
> Minor error API cleanups, and one error reporting improvement when
> connected to qmp (patch #5)
>
> v2:
>     Dropped the error_printf_unless_qmp patch
>     Added the last 4 patches, new cleanups
>     Use error_report instead of fprintf in patch 1 and 2
>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
>
> Cole Robinson (9):
>   slirp: Remove default_mon usage
>   vnc: Remove default_mon usage
>   error: Privatize error_print_loc
>   monitor: Remove unused monitor_print_filename
>   error: Print error_report() to stderr if using qmp
>   qerror.h: Remove unused error classes
>   qerror.h: Remove QERR defines that are only used once
>   qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED
>   error: Remove some unused headers
>
>  block/commit.c              |  2 +-
>  blockdev.c                  |  9 ++++--
>  blockjob.c                  |  2 +-
>  hw/9pfs/virtio-9p.c         |  5 +--
>  hw/core/qdev-properties.c   |  9 +++---
>  hw/misc/ivshmem.c           |  4 +--
>  include/monitor/monitor.h   |  1 -
>  include/qapi/qmp/qerror.h   | 79 ---------------------------------------------
>  include/qemu/error-report.h |  1 -
>  monitor.c                   | 27 ----------------
>  qapi/qmp-dispatch.c         |  3 +-
>  qapi/qmp-input-visitor.c    |  2 +-
>  qdev-monitor.c              | 12 ++++---
>  qmp.c                       |  2 +-
>  qobject/json-parser.c       |  2 +-
>  qom/object.c                |  5 +--
>  savevm.c                    |  3 +-
>  slirp/misc.c                | 13 ++------
>  slirp/slirp.c               |  8 ++---
>  slirp/slirp.h               |  2 --
>  stubs/Makefile.objs         |  1 -
>  stubs/arch-query-cpu-def.c  |  2 +-
>  stubs/mon-print-filename.c  |  6 ----
>  ui/vnc.c                    |  4 +--
>  util/error.c                |  5 +--
>  util/qemu-config.c          |  2 +-
>  util/qemu-error.c           |  4 +--
>  util/qemu-option.c          |  2 +-
>  28 files changed, 50 insertions(+), 167 deletions(-)
>  delete mode 100644 stubs/mon-print-filename.c
>

Nice diffstat. :)

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>