From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>, Cole Robinson <crobinso@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage
Date: Sat, 22 Mar 2014 21:14:22 +0100 [thread overview]
Message-ID: <532DEF1E.3050709@suse.de> (raw)
In-Reply-To: <1394609753.17393.8.camel@nilsson.home.kraxel.org>
Am 12.03.2014 08:35, schrieb Gerd Hoffmann:
> On Di, 2014-03-11 at 19:15 -0400, Cole Robinson wrote:
>> These errors don't seem user initiated, so forcibly printing to the
>> monitor doesn't seem right. Just print to stderr.
>>
>> Cc: Anthony Liguori <aliguori@amazon.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>
> Reviewed-by: Gerd Hoffmann <kraxel@gmail.com>
Both should use error_report(), no? We really need clear-to-understand
rules of when to use which API and then stick with them.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-22 20:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 23:15 [Qemu-devel] [PATCH 0/6] error: Misc cleanups and improvements Cole Robinson
2014-03-11 23:15 ` [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage Cole Robinson
2014-03-12 7:22 ` Jan Kiszka
2014-03-12 13:06 ` Luiz Capitulino
2014-03-22 18:27 ` Andreas Färber
2014-03-22 21:36 ` Cole Robinson
2014-03-12 8:13 ` Markus Armbruster
2014-03-12 13:22 ` Cole Robinson
2014-03-12 14:45 ` Markus Armbruster
2014-03-11 23:15 ` [Qemu-devel] [PATCH 2/6] vnc: " Cole Robinson
2014-03-12 7:35 ` Gerd Hoffmann
2014-03-22 20:14 ` Andreas Färber [this message]
2014-03-11 23:15 ` [Qemu-devel] [PATCH 3/6] error: Privatize error_print_loc Cole Robinson
2014-03-22 20:04 ` Andreas Färber
2014-03-11 23:15 ` [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename Cole Robinson
2014-03-22 20:06 ` Andreas Färber
2014-03-22 21:44 ` Cole Robinson
2014-03-24 13:09 ` Luiz Capitulino
2014-03-24 13:46 ` Andreas Färber
2014-03-26 13:46 ` Markus Armbruster
2014-03-11 23:15 ` [Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp Cole Robinson
2014-03-12 8:56 ` Markus Armbruster
2014-03-21 23:41 ` Cole Robinson
2014-03-11 23:15 ` [Qemu-devel] [PATCH 6/6] error: Print error_report() to stderr if using qmp Cole Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532DEF1E.3050709@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=crobinso@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.