From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 22 Mar 2014 21:49:02 +0100 (CET) Received: from mail-la0-f41.google.com ([209.85.215.41]:49824 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822283AbaCVUs7BEd2m (ORCPT ); Sat, 22 Mar 2014 21:48:59 +0100 Received: by mail-la0-f41.google.com with SMTP id gl10so2687102lab.0 for ; Sat, 22 Mar 2014 13:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=w1ggNHYqTO33nWrUvXpizuJAi/jwdoPdmLNzSaKedfQ=; b=SEbw+PMjRKvtOeVjfkHbmmDZtOkDw4zw03Pu+PLylnPYKDXaSwwBw/mjnfolwKl2D5 uOjNS/wUpB8myKbPyeyjMG/fxcbPLVePHyXJuv2RZPBTj8vyfop/sbkFezx3Xd8I+rEi NhEF8QiRoHKsNZe8yVYrJ9eJm4hYkFmy97iNfPVaMShxiHdMSsOzcgJPDbib5aMkKaMY 0C7LtO3vmI6GAMnSvtj+Mf/Ou6zXFd/w6Wv+N8cjGX6jqhFoBhj+aSzjB+5Y+TqDTs3r 47FjHOqc5MYU1+sE6CiD4rPQazNMk51eq+KkncOAjPpPS+oDPpJekbdOTX3JdXm0DJEz x4SA== X-Gm-Message-State: ALoCoQm2jx5beVEZgDm2/pJuRElCu7xEJuhKBHm7SsxkI41j6RaY5HoeiMxzjfoNaEN2OG7Fq2M1 X-Received: by 10.112.27.133 with SMTP id t5mr20697993lbg.21.1395521333387; Sat, 22 Mar 2014 13:48:53 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp83-237-60-105.pppoe.mtu-net.ru. [83.237.60.105]) by mx.google.com with ESMTPSA id mk5sm8612660lac.6.2014.03.22.13.48.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 22 Mar 2014 13:48:52 -0700 (PDT) Message-ID: <532E053C.90007@cogentembedded.com> Date: Sun, 23 Mar 2014 00:48:44 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Kees Cook , Paul Gortmaker CC: Ralf Baechle , Sanjay Lal , John Crispin , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: export icache_flush_range References: <20140322154720.GA23863@www.outflux.net> <532E0486.3010702@cogentembedded.com> In-Reply-To: <532E0486.3010702@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 39550 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sergei.shtylyov@cogentembedded.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 03/23/2014 12:45 AM, Sergei Shtylyov wrote: >> The lkdtm module performs tests against executable memory ranges, so >> it needs to flush the icache for proper behaviors. Other architectures >> already export this, so do the same for MIPS. >> Signed-off-by: Kees Cook >> --- >> This is currently untested! I'm building a MIPS cross-compiler now... >> If someone can validate this fixes the build when lkdtm is a module, >> that would be appreciated. :) >> --- >> arch/mips/mm/cache.c | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c >> index fde7e56d13fe..b3f1df13d9f6 100644 >> --- a/arch/mips/mm/cache.c >> +++ b/arch/mips/mm/cache.c >> @@ -38,6 +38,7 @@ void (*__flush_kernel_vmap_range)(unsigned long vaddr, int >> size); >> void (*__invalidate_kernel_vmap_range)(unsigned long vaddr, int size); >> >> EXPORT_SYMBOL_GPL(__flush_kernel_vmap_range); >> +EXPORT_SYMBOL_GPL(flush_icache_range); > Have you run this thru scripts/checkpatch.pl? It would have told you that > an export should immediately follow the corresponding function body, AFAIK. Hm, it doesn't now but definitely used to... WBR, Sergei