From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 22 Mar 2014 21:54:49 +0100 (CET) Received: from mail-la0-f49.google.com ([209.85.215.49]:36610 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822136AbaCVUyrtquho (ORCPT ); Sat, 22 Mar 2014 21:54:47 +0100 Received: by mail-la0-f49.google.com with SMTP id mc6so2565376lab.22 for ; Sat, 22 Mar 2014 13:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=W42Xt/OepYh8u4eOhTnu/4WENRbC4LEkJ6X74dduxQk=; b=SPge1OgFLt9QARWYSxslsQn3IM/drSUDnndpU3HSXfqHkrMR3ot+Svph8SGPwvXzF9 GSVfigjxMc64kTHPaJB298MBvMITfmxJhLxQcoV9gnP/JMpk3poXbuNcCIHDmGRYviHo sinojRmXPMI6Vnp+7OlhGWBKYeHIRbbKqH6cmJ18wKZ725g6kNf0GY0BC/pqHhZLEkT4 /UrlKIqO/GEHxKDu3CC85JFrSu9kRWa5GJYW/zMWMlR4aaKl6+O3gL/ZKqCK02IrXs4f 2MDvyqTapJr9KquXV7/4p/xhdRc4MAqRMTVFsijjalvkgZA9/BrNCTSF6RoYBSOnZw57 Fj9w== X-Gm-Message-State: ALoCoQnhYUgeNKBKapzg7h5ETpGq966D9Is1xFopAIaeCgMNEMhY0/yqQ0R8W7dl3MMFPPsRwoW3 X-Received: by 10.112.47.3 with SMTP id z3mr2735448lbm.34.1395521682308; Sat, 22 Mar 2014 13:54:42 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp83-237-60-105.pppoe.mtu-net.ru. [83.237.60.105]) by mx.google.com with ESMTPSA id z6sm6058598lbb.9.2014.03.22.13.54.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 22 Mar 2014 13:54:41 -0700 (PDT) Message-ID: <532E0699.2080303@cogentembedded.com> Date: Sun, 23 Mar 2014 00:54:33 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Kees Cook , Paul Gortmaker CC: Ralf Baechle , Sanjay Lal , John Crispin , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: export icache_flush_range References: <20140322154720.GA23863@www.outflux.net> <532E0486.3010702@cogentembedded.com> <532E053C.90007@cogentembedded.com> In-Reply-To: <532E053C.90007@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 39551 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sergei.shtylyov@cogentembedded.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 03/23/2014 12:48 AM, Sergei Shtylyov wrote: >>> The lkdtm module performs tests against executable memory ranges, so >>> it needs to flush the icache for proper behaviors. Other architectures >>> already export this, so do the same for MIPS. >>> Signed-off-by: Kees Cook >>> --- >>> This is currently untested! I'm building a MIPS cross-compiler now... >>> If someone can validate this fixes the build when lkdtm is a module, >>> that would be appreciated. :) >>> --- >>> arch/mips/mm/cache.c | 1 + >>> 1 file changed, 1 insertion(+) >>> diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c >>> index fde7e56d13fe..b3f1df13d9f6 100644 >>> --- a/arch/mips/mm/cache.c >>> +++ b/arch/mips/mm/cache.c >>> @@ -38,6 +38,7 @@ void (*__flush_kernel_vmap_range)(unsigned long vaddr, int >>> size); >>> void (*__invalidate_kernel_vmap_range)(unsigned long vaddr, int size); >>> >>> EXPORT_SYMBOL_GPL(__flush_kernel_vmap_range); >>> +EXPORT_SYMBOL_GPL(flush_icache_range); >> Have you run this thru scripts/checkpatch.pl? It would have told you that >> an export should immediately follow the corresponding function body, AFAIK. > Hm, it doesn't now but definitely used to... Decided to check Documentation/CodingStyle, and it still codifies this: In source files, separate functions with one blank line. If the function is exported, the EXPORT* macro for it should follow immediately after the closing function brace line. E.g.: int system_is_up(void) { return system_state == SYSTEM_RUNNING; } EXPORT_SYMBOL(system_is_up); WBR, Sergei