From: "Andreas Färber" <afaerber@suse.de>
To: Deepak Kathayat <deepak.mk17@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fixed various typos
Date: Mon, 24 Mar 2014 10:22:27 +0100 [thread overview]
Message-ID: <532FF953.3010702@suse.de> (raw)
In-Reply-To: <1395649817-20742-1-git-send-email-deepak.mk17@gmail.com>
Hi,
Am 24.03.2014 09:30, schrieb Deepak Kathayat:
> Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
> ---
> block/gluster.c | 2 +-
> block/qcow.c | 2 +-
> block/sheepdog.c | 8 ++++----
> block/vdi.c | 2 +-
> block/vhdx-log.c | 2 +-
> slirp/tftp.c | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Note that in general the present tense is preferred, i.e. what is the
patch doing rather than what did you do to create the patch.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Deepak Kathayat <deepak.mk17@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Fixed various typos
Date: Mon, 24 Mar 2014 10:22:27 +0100 [thread overview]
Message-ID: <532FF953.3010702@suse.de> (raw)
In-Reply-To: <1395649817-20742-1-git-send-email-deepak.mk17@gmail.com>
Hi,
Am 24.03.2014 09:30, schrieb Deepak Kathayat:
> Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
> ---
> block/gluster.c | 2 +-
> block/qcow.c | 2 +-
> block/sheepdog.c | 8 ++++----
> block/vdi.c | 2 +-
> block/vhdx-log.c | 2 +-
> slirp/tftp.c | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Note that in general the present tense is preferred, i.e. what is the
patch doing rather than what did you do to create the patch.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-24 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 8:30 [Qemu-trivial] [PATCH] Fixed various typos Deepak Kathayat
2014-03-24 8:30 ` [Qemu-devel] " Deepak Kathayat
2014-03-24 9:22 ` Andreas Färber [this message]
2014-03-24 9:22 ` Andreas Färber
2014-03-25 12:45 ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-25 12:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532FF953.3010702@suse.de \
--to=afaerber@suse.de \
--cc=deepak.mk17@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.