All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Luca Boccassi <Luca.Boccassi@microsoft.com>,
	"bruce.ashfield@gmail.com" <bruce.ashfield@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>
Subject: Re: [OE-core] [PATCH] systemd: dont spew hidepid mount errors for kernels < v5.8
Date: Mon, 18 Jan 2021 12:36:31 +0000	[thread overview]
Message-ID: <532ac1990efd985355f28d565233af87f65db51f.camel@linuxfoundation.org> (raw)
In-Reply-To: <9fa544389d040b0fbacd14a1861cac0721d7d2c0.camel@microsoft.com>

On Fri, 2021-01-15 at 17:35 +0000, Luca Boccassi wrote:
> On Fri, 2021-01-15 at 11:59 -0500, Bruce Ashfield wrote:
> > That code block isn't particularly complex and it is self contained,
> > so really, there's not much to see there. But I'm not in the business
> > of predicting anything, I'm in the wait and see camp (AUH will be the
> > first to pick it up if it causes patch problems, etc).
> > 
> > Richard can either take the change or not, I'm just supporting how
> > it has currently been submitted as chances are that no further
> > revisions are coming from Paul, so it can live or die as-is.
> 
> Even if a patch was preferred to a config, the current patch changes
> too much and should really be reduced in scope, as commented in the
> other email.

Doing this with a patch is probably 'safer' or less ugly than the other
options.

I had meant to test this whilst as the same time,  suggest we reduce
the context in the patch as mentioned, then merge. Unfortunately I
confused the systemd patches and this has sneaked in without that
tweak.

If we could reduce the noise in the diff, that would be useful though. 

Cheers,

Richard







  parent reply	other threads:[~2021-01-18 12:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  5:26 [PATCH] systemd: dont spew hidepid mount errors for kernels < v5.8 Paul Gortmaker
2021-01-15  6:02 ` [OE-core] " Konrad Weihmann
2021-01-15  8:37 ` Richard Purdie
2021-01-15  9:57   ` Luca Boccassi
2021-01-15 10:14     ` Richard Purdie
2021-01-15 10:20       ` Luca Boccassi
2021-01-15 14:47     ` Paul Gortmaker
2021-01-15 15:37       ` Luca Boccassi
2021-01-15 16:07         ` [OE-core] " Bruce Ashfield
2021-01-15 16:31           ` Luca Boccassi
2021-01-15 16:59             ` Bruce Ashfield
2021-01-15 17:35               ` Luca Boccassi
2021-01-18 11:07                 ` Leon Woestenberg
2021-01-18 12:36                 ` Richard Purdie [this message]
2021-01-15 15:27 ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532ac1990efd985355f28d565233af87f65db51f.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Luca.Boccassi@microsoft.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.