From: Paolo Bonzini <pbonzini@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: quintela@redhat.com, zengjunliang <zengjunliang@huawei.com>,
yanqiangjun@huawei.com, lefty.zhao@huawei.com,
owasserm@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel
Date: Mon, 24 Mar 2014 16:47:10 +0100 [thread overview]
Message-ID: <5330537E.7060001@redhat.com> (raw)
In-Reply-To: <1395666264-12060-1-git-send-email-arei.gonglei@huawei.com>
Il 24/03/2014 14:04, arei.gonglei@huawei.com ha scritto:
> From: zengjunliang <zengjunliang@huawei.com>
>
> Return error for migrate cancel, when migration status is not
> MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can
> perceive the operation fails.
>
> Signed-off-by: zengjunliang <zengjunliang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
I think this is done on purpose, because canceling migration is racy.
Instead, libvirt should do "query-migrate" and check if the migration
was completed or canceled.
Paolo
next prev parent reply other threads:[~2014-03-24 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 13:04 [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel arei.gonglei
2014-03-24 14:14 ` Eric Blake
2014-03-24 15:47 ` Paolo Bonzini [this message]
2014-03-24 16:00 ` Eric Blake
2014-03-25 11:15 ` Gonglei (Arei)
2014-03-28 9:18 ` Gonglei (Arei)
2014-03-28 9:28 ` Paolo Bonzini
2014-03-28 11:30 ` Dr. David Alan Gilbert
2014-03-28 12:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5330537E.7060001@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=lefty.zhao@huawei.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yanqiangjun@huawei.com \
--cc=zengjunliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.