From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS7Jc-0006Z3-3i for qemu-devel@nongnu.org; Mon, 24 Mar 2014 12:01:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS7JX-0001rL-PR for qemu-devel@nongnu.org; Mon, 24 Mar 2014 12:01:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS7JX-0001r4-75 for qemu-devel@nongnu.org; Mon, 24 Mar 2014 12:01:27 -0400 Message-ID: <533056A3.5030300@redhat.com> Date: Mon, 24 Mar 2014 10:00:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395666264-12060-1-git-send-email-arei.gonglei@huawei.com> <5330537E.7060001@redhat.com> In-Reply-To: <5330537E.7060001@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lsJOgHr3lVl2JscF8qsDFOnvk6OaF0JN6" Subject: Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: quintela@redhat.com, zengjunliang , "libvir-list@redhat.com" , yanqiangjun@huawei.com, lefty.zhao@huawei.com, owasserm@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lsJOgHr3lVl2JscF8qsDFOnvk6OaF0JN6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [adding libvirt] On 03/24/2014 09:47 AM, Paolo Bonzini wrote: > Il 24/03/2014 14:04, arei.gonglei@huawei.com ha scritto: >> From: zengjunliang >> >> Return error for migrate cancel, when migration status is not >> MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can >> perceive the operation fails. >> >> Signed-off-by: zengjunliang >> Signed-off-by: Gonglei >=20 > I think this is done on purpose, because canceling migration is racy. > Instead, libvirt should do "query-migrate" and check if the migration > was completed or canceled. Can you please give more details at how you are triggering the problem with libvirt? I think Paolo is probably right - the bug is more likely to be in libvirt not expecting the race and not recovering correctly when the race occurs, than it is to be in changing qemu's state algorithm= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lsJOgHr3lVl2JscF8qsDFOnvk6OaF0JN6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTMFajAAoJEKeha0olJ0NqG6oIAKdzpOswPo+xKT2Q4JXt3+yd amXMsFcXYhvXG2rb+GpCb15kgZtB2O8Y40Nd8ea7gGicvrxNIWHxbreVdzsrcy3a xkMmlLE1Gzi+Pr2KB0QkizkQUvwICqFtsSaWBfNmSgCvKBe8/xafExOwFfUeVIiL kl4cRsHq7rDplNVpkvwtx4IdxATRIefVtCOZUUqImXuXDU9bVmhNY3WRzIZRkp7+ XD21qUORk/PA6cqlwmJSLahWy0qqZTOJd7znqwqGB82HCB+9nSVjIBnvLE6PQUi6 mDyFuLTnNYSvw0vdSniIPwRLy+rXbhhaPQiYy0RbuGJTXyjaLyCeBSdZX33v0NI= =BQh/ -----END PGP SIGNATURE----- --lsJOgHr3lVl2JscF8qsDFOnvk6OaF0JN6--