From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSIMS-0001ye-HL for qemu-devel@nongnu.org; Mon, 24 Mar 2014 23:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSIML-0005Zh-39 for qemu-devel@nongnu.org; Mon, 24 Mar 2014 23:49:12 -0400 Received: from mail-yh0-f54.google.com ([209.85.213.54]:42581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSIMK-0005Yr-VM for qemu-devel@nongnu.org; Mon, 24 Mar 2014 23:49:05 -0400 Received: by mail-yh0-f54.google.com with SMTP id f73so6170846yha.27 for ; Mon, 24 Mar 2014 20:49:03 -0700 (PDT) Message-ID: <5330FCA8.3060506@ozlabs.ru> Date: Tue, 25 Mar 2014 14:48:56 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com> <532B645B.5020507@redhat.com> <1395353214.21800.6.camel@localhost.localdomain> <532B6B27.2080105@redhat.com> <1395354837.21800.12.camel@localhost.localdomain> <532B76E5.7090608@redhat.com> <20140323094943.GA6989@redhat.com> <533010B6.8050609@suse.de> In-Reply-To: <533010B6.8050609@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "Michael S. Tsirkin" , Paolo Bonzini Cc: peter.maydell@linaro.org, Marcel Apfelbaum , mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, Laszlo Ersek , rth@twiddle.net On 03/24/2014 10:02 PM, Andreas Färber wrote: > Am 23.03.2014 10:49, schrieb Michael S. Tsirkin: >> On Fri, Mar 21, 2014 at 12:16:53AM +0100, Paolo Bonzini wrote: >>> Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: >>>> I've seen something like that somewhere, but I didn't quite like it. >>>> I was looking for something more elegant as I was *almost* sure >>>> this kind of solution will not pass the reviews :) >>>> >>>> But maybe I'll try this, let's see what happens, >>> >>> If all you're looking for is bigendian (disabling iasl disassembly >>> on bigendian makes sense), your patch v2 is fine. >>> >>> Assembling ASL on bigendian is supported by at least Fedora and >>> Debian (and hence Ubuntu). >>> >>> Paolo >> >> >> At this point I'm confused. >> If iasl compiler is broken, we should detect and fix that. >> It might be ok to just detect endian-ness as a quick work-around. >> BTW configure already has code to detect endian-ness: >> if test "$bigendian" = "yes" ; then >> echo "HOST_WORDS_BIGENDIAN=y" >> $config_host_mak >> fi > > Careful, this is about the endianness of the built target binary, which > may be different from the endianness of the build system. However I > would hope the tests will not be executed for cross-builds. > > Alexey, you're using cross-builds for ppc, right? Have you ever tested > running make check there? "make check" on what? ppc64-softmmu target compiled on x86_64? That fails because of errors like this: tests/check-qjson: tests/check-qjson: cannot execute binary file make: *** [check-tests/check-qstring] Error 1 -- Alexey