Re: [PATCH -tip v8 14/26] x86: Use NOKPROBE_SYMBOL() instead of __kprobes annotation

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2014/03/25 4:45), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:21 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>   
>>  /*
>>   * This is gone through when something in the kernel has done something bad
>> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
>> index ae5aafb..d00103a 100644
>> --- a/arch/x86/kernel/kprobes/core.c
>> +++ b/arch/x86/kernel/kprobes/core.c
>> @@ -112,7 +112,8 @@ struct kretprobe_blackpoint kretprobe_blacklist[] = {
>>  
>>  const int kretprobe_blacklist_size = ARRAY_SIZE(kretprobe_blacklist);
>>  
>> -static void __kprobes __synthesize_relative_insn(void *from, void *to, u8 op)
>> +static nokprobe_inline
>> +void __synthesize_relative_insn(void *from, void *to, u8 op)
> 
> I believe the proper way to break this up is:
> 
> static nokprobe_inline void
> __synthesize_relative_insn(...)

Oops, there are so many incorrect style hunks...:( I'll fix those.

Thank you!


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com