From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Thomas Huth <thuth@linux.vnet.ibm.com>
Subject: Re: [PULL 3/4] KVM: s390: Fix possible memory leak in SIGP functions
Date: Tue, 25 Mar 2014 15:39:41 +0100 [thread overview]
Message-ID: <5331952D.4030408@de.ibm.com> (raw)
In-Reply-To: <53318C82.80600@redhat.com>
On 25/03/14 15:02, Paolo Bonzini wrote:
> Il 25/03/2014 14:35, Christian Borntraeger ha scritto:
>> From: Thomas Huth <thuth@linux.vnet.ibm.com>
>>
>> When kvm_get_vcpu() returned NULL for the destination CPU in
>> __sigp_emergency() or __sigp_external_call(), the memory for the
>> "inti" structure was not released anymore. This patch fixes this
>> issue by moving the check for !dst_vcpu before the kzalloc() call.
>>
>> Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
>> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Should patch 2 and this one have a Cc: stable?
This bug is not yet in 3.14-rc
It is only in kvm/next via commit 1ee0bc559dc34fe36a29494faf7b7c91533bd31c ( KVM: s390: get rid of local_int array)
So no need for stable.
patch 2 just reduces the memory usage from 64 bytes to 8 bytes.
Dont think we should use the stable folks for that.
Christian
next prev parent reply other threads:[~2014-03-25 14:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 13:35 [PULL 0/4] KVM: s390: last fixes for next merge window Christian Borntraeger
2014-03-25 13:35 ` [PULL 1/4] KVM: s390: randomize sca address Christian Borntraeger
2014-03-25 13:53 ` Paolo Bonzini
2014-03-25 14:04 ` Christian Borntraeger
2014-03-25 13:35 ` [PULL 2/4] KVM: s390: fix calculation of idle_mask array size Christian Borntraeger
2014-03-25 13:55 ` Paolo Bonzini
2014-03-25 13:35 ` [PULL 3/4] KVM: s390: Fix possible memory leak in SIGP functions Christian Borntraeger
2014-03-25 14:02 ` Paolo Bonzini
2014-03-25 14:39 ` Christian Borntraeger [this message]
2014-03-25 14:43 ` Paolo Bonzini
2014-03-25 13:35 ` [PULL 4/4] KVM: s390: clear local interrupts at cpu initial reset Christian Borntraeger
2014-03-25 13:56 ` Paolo Bonzini
2014-03-25 14:18 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5331952D.4030408@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.