Re: [PATCH] build: fix sed usage in build process

["Roger Pau Monné" <roger.pau@citrix.com>]

On 25/03/14 17:06, Jan Beulich wrote:
>>>> On 25.03.14 at 16:58, <roger.pau@citrix.com> wrote:
>> On 25/03/14 15:06, Jan Beulich wrote:
>>>>>> On 25.03.14 at 12:20, <roger.pau@citrix.com> wrote:
>>>> FreeBSD sed is not able to correctly parse the script
>>>> '/[0-9]/{s,00*,0,g;p}', so break it into two smaller scripts which
>>>> FreeBSD (and Linux) sed is able to parse.
>>>
>>> First of all - is this again a standard conformance issue? I can't see
>>> what's non-conformant with the old approach (which btw had been
>>> in place for quite long a time, so I'm puzzled by this being an issue
>>> only now), and for future reference purposes it would be nice to
>>> know what exactly should be avoided (i.e. to prevent a similar issue
>>> from getting introduced again later).
>>
>> Sorry, my regex skills are quite basic. The error is the following:
>>
>> sed: 1: "/[0-9]/{s,00*,0,g;p}": extra characters at the end of p command
> 
> Perhaps there's just a ; missing after the p?

Certainly, the following works fine:

sed -n '/[0-9]/{s,00*,0,g;p;}'

Since you are the one that found/fixed it, could you please submit the
patch?

Roger.