From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver
Date: Tue, 25 Mar 2014 10:55:00 -0600 [thread overview]
Message-ID: <5331B4E4.5090101@wwwdotorg.org> (raw)
In-Reply-To: <20140325165159.111863814B8@gemini.denx.de>
On 03/25/2014 10:51 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
>
> In message <5331A6B6.8090805@wwwdotorg.org> you wrote:
>>
>>> Or perhaps update_reg_mask_shift_val()?
>>
>> Still, I can rename the function if you want; it certainly does make it
>> obvious. It's rather a long name though, but I guess wrapping the
>> parameters isn't too bad.
>
> Please do not invent new bit manipulation functions. Just use the
> standard I/O accessors. And whenever possible, please remove pre-
> existing functions.
>
> I've just recently sent patches to get rid of such "inventions" that
> resulted in undefined code.
That's not what this code is doing. The existing IO accessors are used;
it's just removing duplication from the parameters passed to the
existing functions (the shift needs to be written out twice).
next prev parent reply other threads:[~2014-03-25 16:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 18:28 [U-Boot] [PATCH V2 00/13] ARM: tegra: pinmux driver cleanup Stephen Warren
2014-03-21 18:28 ` [U-Boot] [PATCH V2 01/13] ARM: tegra: pinctrl: remove func_safe Stephen Warren
2014-03-21 18:28 ` [U-Boot] [PATCH V2 02/13] ARM: tegra: pinctrl: remove vddio Stephen Warren
2014-03-21 18:28 ` [U-Boot] [PATCH V2 03/13] ARM: tegra: pinctrl: make pmux_func values consistent on Tegra20 Stephen Warren
2014-03-21 18:28 ` [U-Boot] [PATCH V2 04/13] ARM: tegra: prototype pinmux_init() in board.h Stephen Warren
2014-03-21 18:28 ` [U-Boot] [PATCH V2 05/13] ARM: tegra: use apb_misc.h in more places Stephen Warren
2014-03-25 2:17 ` Simon Glass
2014-03-21 18:28 ` [U-Boot] [PATCH V2 06/13] ARM: tegra: pinctrl: remove duplication Stephen Warren
2014-03-25 2:23 ` Simon Glass
2014-03-21 18:28 ` [U-Boot] [PATCH V2 07/13] ARM: tegra: reduce public pinmux API Stephen Warren
2014-03-21 18:28 ` [U-Boot] [PATCH V2 08/13] ARM: tegra: pinmux naming consistency fixes Stephen Warren
2014-03-25 2:24 ` Simon Glass
2014-03-21 18:28 ` [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver Stephen Warren
2014-03-25 2:27 ` Simon Glass
2014-03-25 15:54 ` Stephen Warren
2014-03-25 16:04 ` Simon Glass
2014-03-25 16:28 ` Stephen Warren
2014-03-25 16:51 ` Wolfgang Denk
2014-03-25 16:55 ` Stephen Warren [this message]
2014-03-25 17:03 ` Wolfgang Denk
2014-03-25 17:26 ` Stephen Warren
2014-03-25 19:11 ` Wolfgang Denk
2014-03-21 18:28 ` [U-Boot] [PATCH V2 10/13] ARM: tegra: Tegra20 pinmux cleanup Stephen Warren
2014-03-25 2:29 ` Simon Glass
2014-03-21 18:28 ` [U-Boot] [PATCH V2 11/13] ARM: tegra: Tegra30 " Stephen Warren
2014-03-25 2:30 ` Simon Glass
2014-03-21 18:29 ` [U-Boot] [PATCH V2 12/13] ARM: tegra: Tegra114 " Stephen Warren
2014-03-21 18:29 ` [U-Boot] [PATCH V2 13/13] ARM: tegra: Tegra124 " Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5331B4E4.5090101@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.