From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 25 Mar 2014 10:55:00 -0600
Subject: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in
 pinmux driver
In-Reply-To: <20140325165159.111863814B8@gemini.denx.de>
References: <1395426541-18706-1-git-send-email-swarren@wwwdotorg.org>
	<1395426541-18706-10-git-send-email-swarren@wwwdotorg.org>
	<CAPnjgZ262kWYJEuwEL-+WYKVTd9XxWgT6mzH-XhLirpEKen59Q@mail.gmail.com>
	<5331A6B6.8090805@wwwdotorg.org>
	<20140325165159.111863814B8@gemini.denx.de>
Message-ID: <5331B4E4.5090101@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/25/2014 10:51 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <5331A6B6.8090805@wwwdotorg.org> you wrote:
>>
>>> Or perhaps update_reg_mask_shift_val()?
>>
>> Still, I can rename the function if you want; it certainly does make it
>> obvious. It's rather a long name though, but I guess wrapping the
>> parameters isn't too bad.
> 
> Please do not invent new bit manipulation functions.  Just use the
> standard I/O accessors.  And whenever possible, please remove pre-
> existing functions.
> 
> I've just recently sent patches to get rid of such "inventions" that
> resulted in undefined code.

That's not what this code is doing. The existing IO accessors are used;
it's just removing duplication from the parameters passed to the
existing functions (the shift needs to be written out twice).