From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/ Date: Tue, 25 Mar 2014 10:50:01 -0700 Message-ID: <5331C1C9.5020309@intel.com> References: <1395730215-11604-1-git-send-email-maddy@linux.vnet.ibm.com> <1395730215-11604-2-git-send-email-maddy@linux.vnet.ibm.com> <20140325173605.GA21411@node.dhcp.inet.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140325173605.GA21411@node.dhcp.inet.fi> Sender: owner-linux-mm@kvack.org To: "Kirill A. Shutemov" , Madhavan Srinivasan Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org List-Id: linux-arch.vger.kernel.org On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote: >> > +/* >> > + * Fault around order is a control knob to decide the fault around pages. >> > + * Default value is set to 0UL (disabled), but the arch can override it as >> > + * desired. >> > + */ >> > +#ifndef FAULT_AROUND_ORDER >> > +#define FAULT_AROUND_ORDER 0UL >> > +#endif > FAULT_AROUND_ORDER == 0 case should be handled separately in > do_read_fault(): no reason to go to do_fault_around() if we are going to > fault in only one page. Isn't this the kind of thing we want to do in Kconfig? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:36323 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475AbaCYSGG (ORCPT ); Tue, 25 Mar 2014 14:06:06 -0400 Message-ID: <5331C1C9.5020309@intel.com> Date: Tue, 25 Mar 2014 10:50:01 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/ References: <1395730215-11604-1-git-send-email-maddy@linux.vnet.ibm.com> <1395730215-11604-2-git-send-email-maddy@linux.vnet.ibm.com> <20140325173605.GA21411@node.dhcp.inet.fi> In-Reply-To: <20140325173605.GA21411@node.dhcp.inet.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Kirill A. Shutemov" , Madhavan Srinivasan Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org Message-ID: <20140325175001.pZ4qeC6txMAXZyE9_ui5N8DhOfDOvNY-zABh-eGPfNA@z> On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote: >> > +/* >> > + * Fault around order is a control knob to decide the fault around pages. >> > + * Default value is set to 0UL (disabled), but the arch can override it as >> > + * desired. >> > + */ >> > +#ifndef FAULT_AROUND_ORDER >> > +#define FAULT_AROUND_ORDER 0UL >> > +#endif > FAULT_AROUND_ORDER == 0 case should be handled separately in > do_read_fault(): no reason to go to do_fault_around() if we are going to > fault in only one page. Isn't this the kind of thing we want to do in Kconfig? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ozlabs.org (Postfix) with ESMTP id 97753140086 for ; Wed, 26 Mar 2014 05:06:07 +1100 (EST) Message-ID: <5331C1C9.5020309@intel.com> Date: Tue, 25 Mar 2014 10:50:01 -0700 From: Dave Hansen MIME-Version: 1.0 To: "Kirill A. Shutemov" , Madhavan Srinivasan Subject: Re: [PATCH 1/1] mm: move FAULT_AROUND_ORDER to arch/ References: <1395730215-11604-1-git-send-email-maddy@linux.vnet.ibm.com> <1395730215-11604-2-git-send-email-maddy@linux.vnet.ibm.com> <20140325173605.GA21411@node.dhcp.inet.fi> In-Reply-To: <20140325173605.GA21411@node.dhcp.inet.fi> Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-arch@vger.kernel.org, riel@redhat.com, rusty@rustcorp.com.au, peterz@infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ak@linux.intel.com, paulus@samba.org, mgorman@suse.de, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org, kirill.shutemov@linux.intel.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote: >> > +/* >> > + * Fault around order is a control knob to decide the fault around pages. >> > + * Default value is set to 0UL (disabled), but the arch can override it as >> > + * desired. >> > + */ >> > +#ifndef FAULT_AROUND_ORDER >> > +#define FAULT_AROUND_ORDER 0UL >> > +#endif > FAULT_AROUND_ORDER == 0 case should be handled separately in > do_read_fault(): no reason to go to do_fault_around() if we are going to > fault in only one page. Isn't this the kind of thing we want to do in Kconfig?