From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5B3271400C5 for ; Wed, 26 Mar 2014 05:19:37 +1100 (EST) Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Mar 2014 12:19:34 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 48FA81FF003B for ; Tue, 25 Mar 2014 12:19:32 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08026.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2PIIvcb63242478 for ; Tue, 25 Mar 2014 19:18:57 +0100 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2PIJVPP031440 for ; Tue, 25 Mar 2014 12:19:31 -0600 Message-ID: <5331C8A3.7070204@linux.vnet.ibm.com> Date: Tue, 25 Mar 2014 11:19:15 -0700 From: Cody P Schafer MIME-Version: 1.0 To: Anton Blanchard Subject: Re: [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface References: <1394064082-6242-1-git-send-email-cody@linux.vnet.ibm.com> <1394064082-6242-10-git-send-email-cody@linux.vnet.ibm.com> <20140325214356.4a2f7d95@kryten> In-Reply-To: <20140325214356.4a2f7d95@kryten> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Peter Zijlstra , LKML , Michael Ellerman , Ingo Molnar , Paul Mackerras , Arnaldo Carvalho de Melo , scottwood@freescale.com, Linux PPC List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/25/2014 03:43 AM, Anton Blanchard wrote: > > Hi Cody, > > hv-24x7: could not obtain capabilities, error 0x fffffffffffffffe, not enabling > hv-gpci: could not obtain capabilities, error 0x fffffffffffffffe, not enabling > >> + pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n", > > That's a lot of padding :) > > I think this should also be a pr_debug, considering this is not relevant > to most ppc64 boxes. I'm fine with that. It should probably be "0x%08lx" not "0x%80lx", not sure when I screwed that up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbaCYSTh (ORCPT ); Tue, 25 Mar 2014 14:19:37 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:55610 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbaCYSTf (ORCPT ); Tue, 25 Mar 2014 14:19:35 -0400 Message-ID: <5331C8A3.7070204@linux.vnet.ibm.com> Date: Tue, 25 Mar 2014 11:19:15 -0700 From: Cody P Schafer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Anton Blanchard CC: Linux PPC , Peter Zijlstra , LKML , Michael Ellerman , Ingo Molnar , Paul Mackerras , Arnaldo Carvalho de Melo , scottwood@freescale.com Subject: Re: [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface References: <1394064082-6242-1-git-send-email-cody@linux.vnet.ibm.com> <1394064082-6242-10-git-send-email-cody@linux.vnet.ibm.com> <20140325214356.4a2f7d95@kryten> In-Reply-To: <20140325214356.4a2f7d95@kryten> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14032518-0928-0000-0000-000000AC611A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/2014 03:43 AM, Anton Blanchard wrote: > > Hi Cody, > > hv-24x7: could not obtain capabilities, error 0x fffffffffffffffe, not enabling > hv-gpci: could not obtain capabilities, error 0x fffffffffffffffe, not enabling > >> + pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n", > > That's a lot of padding :) > > I think this should also be a pr_debug, considering this is not relevant > to most ppc64 boxes. I'm fine with that. It should probably be "0x%08lx" not "0x%80lx", not sure when I screwed that up.