All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Sebastian Capella <sebastian.capella@linaro.org>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
	"Len Brown" <len.brown@intel.com>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Jonathan Austin" <jonathan.austin@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Victor Kamensky" <victor.kamensky@linaro.org>,
	"Will Deacon" <will.deacon@arm.com>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Sricharan R" <r.sricharan@ti.com>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Ben Dooks" <ben.dooks@codethink.co.uk>,
	"Russ Dill" <Russ.Dill@ti.com>, "Nicolas Pitre" <nico@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Laura Abbott" <lauraa@codeaurora.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Stephen Boyd" <sboyd@codeaurora.org>
Subject: Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk
Date: Wed, 26 Mar 2014 00:36:49 +0100	[thread overview]
Message-ID: <53321311.8060604@ahsoftware.de> (raw)
In-Reply-To: <5331CD43.1010601@ahsoftware.de>

Am 25.03.2014 19:38, schrieb Alexander Holler:

> reboot too. Another solution would be to unregister the reboot_notifier
> in the reboot_nofifier itself. I've just seen one watchdog driver
> (drivers/rtc/rtc-m41t80.c) which does that. But I still think such

That, btw. is broken. ;)

Right after having send the mail, I've became that intuition, had a look 
and ... notifier.h does state the following:

  * atomic_notifier_chain_unregister(), 
blocking_notifier_chain_unregister(),
  * and srcu_notifier_chain_unregister() _must not_ be called from within
  * the call chain.

(The reboot-notifier chain is of type blocking_notifier_chain)

So I've picked up one user of reboot_notifier by random and had the luck 
to choose a broken one. ;)

I will make a patch and will have a look if the same failure can be 
found elsewhere. There aren't that much users of the reboot-notifier, so 
it shouldn't cost me that much time.

Regards,

Alexander Holler



WARNING: multiple messages have this Message-ID (diff)
From: holler@ahsoftware.de (Alexander Holler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 2/2] ARM hibernation / suspend-to-disk
Date: Wed, 26 Mar 2014 00:36:49 +0100	[thread overview]
Message-ID: <53321311.8060604@ahsoftware.de> (raw)
In-Reply-To: <5331CD43.1010601@ahsoftware.de>

Am 25.03.2014 19:38, schrieb Alexander Holler:

> reboot too. Another solution would be to unregister the reboot_notifier
> in the reboot_nofifier itself. I've just seen one watchdog driver
> (drivers/rtc/rtc-m41t80.c) which does that. But I still think such

That, btw. is broken. ;)

Right after having send the mail, I've became that intuition, had a look 
and ... notifier.h does state the following:

  * atomic_notifier_chain_unregister(), 
blocking_notifier_chain_unregister(),
  * and srcu_notifier_chain_unregister() _must not_ be called from within
  * the call chain.

(The reboot-notifier chain is of type blocking_notifier_chain)

So I've picked up one user of reboot_notifier by random and had the luck 
to choose a broken one. ;)

I will make a patch and will have a look if the same failure can be 
found elsewhere. There aren't that much users of the reboot-notifier, so 
it shouldn't cost me that much time.

Regards,

Alexander Holler

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Holler <holler@ahsoftware.de>
To: Sebastian Capella <sebastian.capella@linaro.org>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
	"Len Brown" <len.brown@intel.com>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Jonathan Austin" <jonathan.austin@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Victor Kamensky" <victor.kamensky@linaro.org>,
	"Will Deacon" <will.deacon@arm.com>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Sricharan R" <r.sricharan@ti.com>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Ben Dooks" <ben.dooks@codethink.co.uk>,
	"Russ Dill" <Russ.Dill@ti.com>, "Nicolas Pitre" <nico@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Laura Abbott" <lauraa@codeaurora.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Stephen Boyd" <sboyd@codeaurora.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Jiang Liu" <liuj97@gmail.com>
Subject: Re: [PATCH v7 2/2] ARM hibernation / suspend-to-disk
Date: Wed, 26 Mar 2014 00:36:49 +0100	[thread overview]
Message-ID: <53321311.8060604@ahsoftware.de> (raw)
In-Reply-To: <5331CD43.1010601@ahsoftware.de>

Am 25.03.2014 19:38, schrieb Alexander Holler:

> reboot too. Another solution would be to unregister the reboot_notifier
> in the reboot_nofifier itself. I've just seen one watchdog driver
> (drivers/rtc/rtc-m41t80.c) which does that. But I still think such

That, btw. is broken. ;)

Right after having send the mail, I've became that intuition, had a look 
and ... notifier.h does state the following:

  * atomic_notifier_chain_unregister(), 
blocking_notifier_chain_unregister(),
  * and srcu_notifier_chain_unregister() _must not_ be called from within
  * the call chain.

(The reboot-notifier chain is of type blocking_notifier_chain)

So I've picked up one user of reboot_notifier by random and had the luck 
to choose a broken one. ;)

I will make a patch and will have a look if the same failure can be 
found elsewhere. There aren't that much users of the reboot-notifier, so 
it shouldn't cost me that much time.

Regards,

Alexander Holler



  parent reply	other threads:[~2014-03-25 23:48 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 10:50 [PATCH v7 0/2] hibernation support on ARM Sebastian Capella
2014-03-05 10:50 ` Sebastian Capella
2014-03-05 10:50 ` [PATCH v7 1/2] ARM: avoid tracers in soft_restart Sebastian Capella
2014-03-05 10:50   ` Sebastian Capella
2014-03-06 23:45   ` Sebastian Capella
2014-03-06 23:45     ` Sebastian Capella
2014-03-06 23:45     ` Sebastian Capella
2014-03-19 23:26     ` Sebastian Capella
2014-03-19 23:26       ` Sebastian Capella
2014-03-05 10:50 ` [PATCH v7 2/2] ARM hibernation / suspend-to-disk Sebastian Capella
2014-03-05 10:50   ` Sebastian Capella
2014-03-07  4:21   ` Sebastian Capella
2014-03-07  4:21     ` Sebastian Capella
2014-03-07  4:21     ` Sebastian Capella
2014-03-07  4:42   ` Stephen Boyd
2014-03-07  4:42     ` Stephen Boyd
2014-03-10 18:32     ` Sebastian Capella
2014-03-10 18:32       ` Sebastian Capella
2014-03-10 18:32       ` Sebastian Capella
2014-03-16  9:46       ` Russell King - ARM Linux
2014-03-16  9:46         ` Russell King - ARM Linux
2014-03-16  9:46         ` Russell King - ARM Linux
2014-03-17 22:07         ` Sebastian Capella
2014-03-17 22:07           ` Sebastian Capella
2014-03-17 22:07           ` Sebastian Capella
2014-03-16  7:09   ` Ezequiel Garcia
2014-03-16  7:09     ` Ezequiel Garcia
2014-03-16  7:09     ` Ezequiel Garcia
2014-03-17 19:10     ` Sebastian Capella
2014-03-17 19:10       ` Sebastian Capella
2014-03-17 19:10       ` Sebastian Capella
2014-03-17 20:44       ` Ezequiel Garcia
2014-03-17 20:44         ` Ezequiel Garcia
2014-03-17 20:44         ` Ezequiel Garcia
2014-03-17 22:39         ` Sebastian Capella
2014-03-17 22:39           ` Sebastian Capella
2014-03-17 22:39           ` Sebastian Capella
2014-03-19 15:44           ` Ezequiel Garcia
2014-03-19 15:44             ` Ezequiel Garcia
2014-03-19 15:44             ` Ezequiel Garcia
2014-03-19 20:47             ` Sebastian Capella
2014-03-19 20:47               ` Sebastian Capella
2014-03-19 20:47               ` Sebastian Capella
2014-03-19 21:06               ` Sebastian Capella
2014-03-19 21:06                 ` Sebastian Capella
2014-03-19 21:06                 ` Sebastian Capella
2014-03-24 18:06                 ` Sebastian Capella
2014-03-24 18:06                   ` Sebastian Capella
2014-03-24 18:06                   ` Sebastian Capella
2014-03-25 18:38                 ` Alexander Holler
2014-03-25 18:38                   ` Alexander Holler
2014-03-25 18:38                   ` Alexander Holler
2014-03-25 18:48                   ` Sebastian Capella
2014-03-25 18:48                     ` Sebastian Capella
2014-03-25 18:48                     ` Sebastian Capella
2014-03-25 23:36                   ` Alexander Holler [this message]
2014-03-25 23:36                     ` Alexander Holler
2014-03-25 23:36                     ` Alexander Holler
2014-03-26  0:00                     ` Alexander Holler
2014-03-26  0:00                       ` Alexander Holler
2014-03-26  0:00                       ` Alexander Holler
2014-03-20  3:02             ` TonyHo
2014-03-20  3:02               ` TonyHo
2014-03-20 17:26               ` Sebastian Capella
2014-03-20 17:26                 ` Sebastian Capella
2014-03-20 17:26                 ` Sebastian Capella
2014-04-16 10:12   ` Russell King - ARM Linux
2014-04-16 10:12     ` Russell King - ARM Linux
2014-04-16 16:42     ` Sebastian Capella
2014-04-16 16:42       ` Sebastian Capella
2014-04-16 16:42       ` Sebastian Capella
2014-04-17 20:38       ` Sebastian Capella
2014-04-17 20:38         ` Sebastian Capella
2014-04-17 20:38         ` Sebastian Capella
2014-04-23  0:38         ` Sebastian Capella
2014-04-23  0:38           ` Sebastian Capella
2014-04-23  0:38           ` Sebastian Capella
2014-04-23 16:39           ` Sebastian Capella
2014-04-23 16:39             ` Sebastian Capella
2014-04-23 16:39             ` Sebastian Capella
2014-05-07 15:37             ` Pavel Machek
2014-05-07 15:37               ` Pavel Machek
2014-05-07 15:37               ` Pavel Machek
2014-05-07 22:20               ` Sebastian Capella
2014-05-07 22:20                 ` Sebastian Capella
2014-05-07 22:20                 ` Sebastian Capella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53321311.8060604@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=Russ.Dill@ti.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=catalin.marinas@arm.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=jonathan.austin@arm.com \
    --cc=lauraa@codeaurora.org \
    --cc=len.brown@intel.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nico@linaro.org \
    --cc=r.sricharan@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=sboyd@codeaurora.org \
    --cc=sebastian.capella@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=victor.kamensky@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.