From: "H. Peter Anvin" <hpa@linux.intel.com>
To: David Miller <davem@davemloft.net>, dborkman@redhat.com
Cc: ast@plumgrid.com, netdev@vger.kernel.org, hagen@jauu.net,
keescook@chromium.org, pmoore@redhat.com, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 8/9] net: filter: rework/optimize internal BPF interpreter's instruction set
Date: Tue, 25 Mar 2014 17:24:27 -0700 [thread overview]
Message-ID: <53321E3B.8080709@linux.intel.com> (raw)
In-Reply-To: <20140325.201712.1651156258234145348.davem@davemloft.net>
On 03/25/2014 05:17 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Tue, 25 Mar 2014 13:10:56 +0100
>
>> - Conditional jt/jf targets replaced with jt/fall-through,
>> and forward/backward jumps now possible as well
>
> Ummm... does anyone even remember why backwards jumps were not allowed
> in the original BPF?
>
> It's to guarentee forward progress in the filter.
>
> Allowing branching backward would allow endless loops.
>
> Please remove this feature.
>
If you allow loops, it greatly increases the expressibility of the
language, but we would really need another control to limit CPU usage.
-hpa
next prev parent reply other threads:[~2014-03-26 0:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 12:10 [PATCH net-next v2 0/9] BPF updates Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 1/9] net: filter: add jited flag to indicate jit compiled filters Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 2/9] net: filter: keep original BPF program around Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 3/9] net: filter: move filter accounting to filter core Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 4/9] net: ptp: use sk_unattached_filter_create() for BPF Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 5/9] net: ptp: do not reimplement PTP/BPF classifier Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 6/9] net: ppp: use sk_unattached_filter api Daniel Borkmann
2014-03-25 12:10 ` Daniel Borkmann
2014-03-25 12:10 ` [PATCH net-next v2 7/9] net: isdn: " Daniel Borkmann
2014-03-25 23:08 ` David Miller
2014-03-25 12:10 ` [PATCH net-next v2 8/9] net: filter: rework/optimize internal BPF interpreter's instruction set Daniel Borkmann
2014-03-26 0:17 ` David Miller
2014-03-26 0:24 ` H. Peter Anvin [this message]
2014-03-26 0:46 ` David Miller
2014-03-26 1:58 ` Alexei Starovoitov
2014-03-26 16:22 ` David Miller
2014-03-25 12:10 ` [PATCH net-next v2 9/9] doc: filter: extend BPF documentation to document new internals Daniel Borkmann
2014-03-25 15:02 ` [PATCH net-next v2 0/9] BPF updates David Miller
2014-03-25 15:06 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53321E3B.8080709@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=hagen@jauu.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmoore@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.