All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_tables: Add meta expression key for bridge interface name
Date: Wed, 26 Mar 2014 09:15:31 +0200	[thread overview]
Message-ID: <53327E93.3040601@linux.intel.com> (raw)
In-Reply-To: <20140325204331.GA3491@localhost>

Hi Pablo,

> I really think we have to use Patrick's new infrastructure that allows
> us to add new expression flavours per family.

I actually used this, look at the end of the patch.
However, since I did not wanted to rewrite a specific 
nft_meta_select_ops, I used this trick.
Makes it messy anyway yes, I will change that.

>   It should just need a
> couple of exported symbols in nft_meta.c that you can use from the new
> net/bridge/netfilter/nft_meta.c file. We should avoid these ifdef
> games.

I agree, looks ugly.

Will prepare a proper patch

Tomasz

  reply	other threads:[~2014-03-26  7:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25 16:39 [PATCH] netfilter: nf_tables: Add meta expression key for bridge interface name Tomasz Bursztyka
2014-03-25 16:42 ` Tomasz Bursztyka
2014-03-25 20:43 ` Pablo Neira Ayuso
2014-03-26  7:15   ` Tomasz Bursztyka [this message]
2014-03-26 12:12 ` Patrick McHardy
2014-03-26 13:06   ` Tomasz Bursztyka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53327E93.3040601@linux.intel.com \
    --to=tomasz.bursztyka@linux.intel.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.