From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aer-iport-2.cisco.com ([173.38.203.52]:52937 "EHLO aer-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbaCZJxc (ORCPT ); Wed, 26 Mar 2014 05:53:32 -0400 Message-ID: <5332A35E.3000504@cisco.com> Date: Wed, 26 Mar 2014 10:52:30 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Laurent Pinchart CC: linux-media@vger.kernel.org, Hans Verkuil , Lars-Peter Clausen Subject: Re: [PATCH] adv7611: Set HPD GPIO direction to output References: <1395800929-17036-1-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1395800929-17036-1-git-send-email-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Laurent, Stupid question perhaps, but why is gpiod_set_value_cansleep() removed? Does setting the output direction force the value to 0 as well? Regards, Hans On 03/26/14 03:28, Laurent Pinchart wrote: > The HPD GPIO is used as an output but its direction is never set. Fix > it. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/i2c/adv7604.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch applies on top of the ADV7611 support series queued for v3.16. > > diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c > index 51f14ab..b38ebb9 100644 > --- a/drivers/media/i2c/adv7604.c > +++ b/drivers/media/i2c/adv7604.c > @@ -2845,7 +2845,7 @@ static int adv7604_probe(struct i2c_client *client, > if (IS_ERR(state->hpd_gpio[i])) > continue; > > - gpiod_set_value_cansleep(state->hpd_gpio[i], 0); > + gpiod_direction_output(state->hpd_gpio[i], 0); > > v4l_info(client, "Handling HPD %u GPIO\n", i); > } >