From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 15/17] xen: arm64: optimised clear_page
Date: Wed, 26 Mar 2014 14:16:06 +0000
Message-ID: <5332E126.2020907@linaro.org>
References: <1395841009.12547.11.camel@kazak.uk.xensource.com>
	<1395841133-2223-15-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395841133-2223-15-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 03/26/2014 01:38 PM, Ian Campbell wrote:
> Taken from Linux v3.14-rc7.
> 
> The clear_page header now needs to be within the !__ASSEMBLY__
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---

[..]

> +
> +#ifdef CONFIG_ARM_32
> +#define clear_page(page) memset((void *)(page), 0, PAGE_SIZE)
> +#else
> +extern void clear_page(void *to);
> +#endif
> +

I would prefer if you move the defined in arm{32,64}/page.h.

Regards,

-- 
Julien Grall