From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] xen/x86: Identify which vcpu's CR4 is
 being badly modified
Date: Wed, 26 Mar 2014 14:22:07 +0000
Message-ID: <5332E28F.9040101@citrix.com>
References: <5332E65A02000078000025ED@nat28.tlf.novell.com>
	<1395842453-10305-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395842453-10305-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Please ignore this - I appear to have gained the new patch message with
the old patch.  I shall try to correct.

~Andrew

On 26/03/14 14:00, Andrew Cooper wrote:
> When the toolstack is setting vcpu state on behalf of a migrating guest, the
> domain/vcpu reference from gdprintk() identifies the toolstack, not the
> affected domain.
>
> After this change, the error looks more like:
>
>   (XEN) d0 attempted to change d6v0's CR4 flags 00002660 -> 01876000
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
>
> ---
> v2: gdprintk -> printk, drop current's vcpu reference.
> ---
>  xen/arch/x86/domain.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index b48f2dc..59e2729 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -652,8 +652,8 @@ unsigned long pv_guest_cr4_fixup(const struct vcpu *v, unsigned long guest_cr4)
>  
>      if ( (guest_cr4 & hv_cr4_mask) != (hv_cr4 & hv_cr4_mask) )
>          gdprintk(XENLOG_WARNING,
> -                 "Attempt to change CR4 flags %08lx -> %08lx\n",
> -                 hv_cr4, guest_cr4);
> +                 "Attempt to change %pv's CR4 flags %08lx -> %08lx\n",
> +                 v, hv_cr4, guest_cr4);
>  
>      return (hv_cr4 & hv_cr4_mask) | (guest_cr4 & ~hv_cr4_mask);
>  }