From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Allow override of phonesim conf
Date: Wed, 26 Mar 2014 10:49:06 -0500 [thread overview]
Message-ID: <5332F6F2.5090507@gmail.com> (raw)
In-Reply-To: <5332B979.1010604@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
Hi Jussi,
On 03/26/2014 06:26 AM, Jussi Pakkanen wrote:
> Hi
>
> Currently phonesim tries to open its conf file from the location
> specified at configure time (/etc/ofono/phonesim.conf). For testing
> purposes it would be nice to be able to override this. This patch allows
> you to override the location with the environment variable
> OFONO_PHONESIM_CONFIG.
Can you please use git send-email to submit patches.
Also, the coding style in the patch is incorrect. Please review
doc/coding-style.txt and the kernel coding style guidelines.
Specifically the use of {} in if/else statements.
Regards,
-Denis
prev parent reply other threads:[~2014-03-26 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 11:26 [PATCH] Allow override of phonesim conf Jussi Pakkanen
2014-03-26 15:49 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332F6F2.5090507@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.