Re: [Qemu-devel] [PULL 0/8] tcg-ia64 ldst updates

[Richard Henderson <rth@twiddle.net>]

On 03/06/2014 02:10 PM, Aurelien Jarno wrote:
> On Tue, Mar 04, 2014 at 11:00:59AM -0800, Richard Henderson wrote:
>> This is a revival of a patch set I submitted back in September.
> 
> Well the patch set from September was much different and was followed by
> a new version in October to which I answered, and even acked a few
> patches.

Indeed, all the patches you acked got applied back then.

>> I've just re-tested it and things still look ok, so I'm just going
>> to ask for a pull rather than pretending there might be review.
> 
> Anyway this new version still doesn't work for 64-bit big endian guest,
> so this is a NACK. This can be easily tested with for example a MIPS64
> guest using these images: http://people.debian.org/~aurel32/qemu/mips/

Thanks for the pointer.  There was indeed a problem with bswap'ed signed loads.
 I'll repost sometime today, but only change aside from rebase is

             int shift = 64 - (8 << s_bits);
-            bswap2 = tcg_opc_i11(TCG_REG_P6, OPC_EXTR_U_I11,
-                                 TCG_REG_R8, TCG_REG_R8, shift, 63 - shift);
+            bswap2 = (opc & MO_SIGN ? OPC_EXTR_I11 : OPC_EXTR_U_I11);
+            bswap2 = tcg_opc_i11(TCG_REG_P6, bswap2,
+                                 TCG_REG_R8, TCG_REG_R8, shift, 63 - shift);



r~