All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] drm/i915: Simplify page allocation loop a bit
Date: Wed, 26 Mar 2014 17:33:04 +0000	[thread overview]
Message-ID: <53330F50.7030304@linux.intel.com> (raw)
In-Reply-To: <20140326171149.GC29626@nuc-i3427.alporthouse.com>


On 03/26/2014 05:11 PM, Chris Wilson wrote:
> On Wed, Mar 26, 2014 at 04:48:47PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Looks like there are some redundant lines in the main loop of
>> i915_gem_object_get_pages_gtt.
>>
>> I haven't tested this so just RFC please.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Imre Deak <imre.deak@intel.com>
>
> I am pretty sure we can't drop CONFIG_SWIOTLB as swiotlb_nr_tbl only
> exists when lib/swiotlb.c is built i.e. #if IS_ENABLED(CONFIG_SWIOTLB).

I think you're right. I'll repost. Although it diminishes the 
attractiveness of the whole line reducing enterprise a bit.

Thanks,

Tvrtko

  reply	other threads:[~2014-03-26 17:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26 16:48 [RFC] drm/i915: Simplify page allocation loop a bit Tvrtko Ursulin
2014-03-26 16:58 ` Imre Deak
2014-03-26 17:11 ` Chris Wilson
2014-03-26 17:33   ` Tvrtko Ursulin [this message]
2014-03-27 10:18 ` Tvrtko Ursulin
2014-03-27 10:40   ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53330F50.7030304@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.