From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] beecrypt: only build C++ support if dependencies are available
Date: Wed, 26 Mar 2014 18:36:05 +0100 [thread overview]
Message-ID: <53331005.4070306@mind.be> (raw)
In-Reply-To: <20140326150517.4F60E9C3B2@busybox.osuosl.org>
On 26/03/14 16:01, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=205839d085508b83d9437f2fbe002ef076aa0cdb
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Instead of automatically pulling in the (big) icu library if the toolchain
> dependencies are available.
Wouldn't it be more appropriate to make an explicit config option for it
then? I think this one falls under the category "Not obvious to the user
that he should select library XXX to enable feature YYY."
Patch follows.
Regards,
Arnout
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/beecrypt/Config.in | 7 -------
> package/beecrypt/beecrypt.mk | 2 +-
> 2 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/package/beecrypt/Config.in b/package/beecrypt/Config.in
> index 8d63e5e..84754e5 100644
> --- a/package/beecrypt/Config.in
> +++ b/package/beecrypt/Config.in
> @@ -1,8 +1,6 @@
> config BR2_PACKAGE_BEECRYPT
> bool "beecrypt"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> - select BR2_PACKAGE_ICU if BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && \
> - !BR2_arc && !BR2_BINFMT_FLAT
> help
> Beecrypt is a general-purpose cryptography library.
>
> @@ -10,8 +8,3 @@ config BR2_PACKAGE_BEECRYPT
>
> comment "beecrypt needs a toolchain w/ threads"
> depends on !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "beecrypt C++ support needs a toolchain w/ wchar"
> - depends on !BR2_arc
> - depends on !BR2_BINFMT_FLAT
> - depends on BR2_INSTALL_LIBSTDCPP && !BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/beecrypt/beecrypt.mk b/package/beecrypt/beecrypt.mk
> index 223b44f..c77782c 100644
> --- a/package/beecrypt/beecrypt.mk
> +++ b/package/beecrypt/beecrypt.mk
> @@ -22,7 +22,7 @@ BEECRYPT_CONF_OPT = \
> --without-python \
> --disable-openmp
>
> -ifeq ($(BR2_PACKAGE_ICU),y)
> +ifeq ($(BR2_INSTALL_LIBSTDCPP)$(BR2_USE_WCHAR)$(BR2_PACKAGE_ICU),yyy)
> # C++ support needs icu
> BEECRYPT_DEPENDENCIES += icu
> else
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-03-26 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 15:01 [Buildroot] [git commit] beecrypt: only build C++ support if dependencies are available Peter Korsgaard
2014-03-26 17:36 ` Arnout Vandecappelle [this message]
2014-03-26 21:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53331005.4070306@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.