nouveau.c

nouveau.c

[Daniel Melo Jorge da Cunha]

[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]

Hi, I am inspecting the file nouveau.c...
In the function nouveau_client_new there is the
following:

for (i = 0; i < nvdev->nr_client; i++) {

but "nr_client" has no previous assignment

so it has scrambled data. Is this expected behaviour
or am I missing something (the most probable :)?

And someone please tell me where do I find that ffs function.

Thanks in advance!!

[-- Attachment #1.2: Type: text/html, Size: 722 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: nouveau.c

[Ilia Mirkin]

struct nouveau_device_priv *nvdev = calloc(1, sizeof(*nvdev));

calloc sets the entire structure to 0. so that field is implicitly set
to 0 on allocation.

On Wed, Mar 26, 2014 at 4:37 PM, Daniel Melo Jorge da Cunha
<dmjcunha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi, I am inspecting the file nouveau.c...
> In the function nouveau_client_new there is the
> following:
>
> for (i = 0; i < nvdev->nr_client; i++) {
>
> but "nr_client" has no previous assignment
>
> so it has scrambled data. Is this expected behaviour
> or am I missing something (the most probable :)?
>
> And someone please tell me where do I find that ffs function.
>
> Thanks in advance!!
>
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
>

Re: nouveau.c

[Peter Hurley]

On 03/26/2014 04:37 PM, Daniel Melo Jorge da Cunha wrote:
> And someone please tell me where do I find that ffs function.

ffs() is defined either by the arch
(eg., arch/x86/include/asm/bitops.h) or, if not implemented by
the arch, then generically in include/asm-generic/bitops/ffs.h

This is common pattern for many arch-dependent implementation
details.

Regards,
Peter Hurley